Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing gpp_sid in url query parameters #85

Open
smounitz opened this issue Jul 6, 2023 · 2 comments · May be fixed by #117
Open

Passing gpp_sid in url query parameters #85

smounitz opened this issue Jul 6, 2023 · 2 comments · May be fixed by #117

Comments

@smounitz
Copy link

smounitz commented Jul 6, 2023

I need clarity regarding passing gpp_sid in url query parameters:

The specs (last line on this page ) say it should be a comma separated string (ex: gpp_sid=6,8) but I see a lot of request with the string enclosed in square brackets (ex: gpp_sid=[6,8])

@janwinkler
Copy link

I think the spec is clear here that the value should be a comma list. There is no talk about any [...] and the example URL also does not include any [...]:
http://vendor-a.com/key1=val1&key2=val2&gpp=DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN&gpp_sid=2

Maybe we can make the example more clear for this case and write:
http://vendor-a.com/key1=val1&key2=val2&gpp=DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN&gpp_sid=2,5
(@jaredmoscow @lamrowena )

@janwinkler
Copy link

Actually the comma is not websafe and should be avoided. Maybe a spec update could use underscore, dot or minus instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants