Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pitch & yaw argument to automata core #597

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Apr 26, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements

It technically fixed #419, but I did not test on what #419 said, because Idk which item should I use. If anyone know which tool can break multiple blocks same time with specific direction please let me know.

Note: negative yaw means turn left, negative pitch means turn up

@SirEdvin
Copy link
Collaborator

Hm, I am not sure, but this can result in even more confusing API, isn't it?

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 27, 2024

Hm, I am not sure, but this can result in even more confusing API, isn't it?

At least it's easier than inventory APIs 🥇

Add yaw and pitch will allow player to place or dig any shape they want, if the fake player works as indeed

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 27, 2024

Or as alternative, do you think add another API to turn the fake player will be better? e.g.

core.setPitch(pitch)
core.setYaw(yaw)
core.digBlock()

@zyxkad zyxkad marked this pull request as draft April 27, 2024 20:06
@zyxkad zyxkad marked this pull request as ready for review April 28, 2024 00:57
@zyxkad zyxkad merged commit 5dc15af into IntelligenceModding:dev/1.19.2 Apr 30, 2024
2 checks passed
@zyxkad zyxkad deleted the 419-patch branch April 30, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shift/sneaking version of useOnBlock
3 participants