-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pitch & yaw argument to automata core #597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hm, I am not sure, but this can result in even more confusing API, isn't it? |
At least it's easier than inventory APIs 🥇 Add yaw and pitch will allow player to place or dig any shape they want, if the fake player works as indeed |
Or as alternative, do you think add another API to turn the fake player will be better? e.g. core.setPitch(pitch)
core.setYaw(yaw)
core.digBlock() |
Merged
3 tasks
SirEndii
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
useOnBlock
Advanced-Peripherals-Features#9What is the new behavior (if this is a feature change)?
Make the signature to
useOnBlock({pitch = optional number, yaw = optional number, sneak = optional bool})
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
It didn't make any breaking change to script API, but maybe changed some Java API logic
Other information:
It technically fixed #419, but I did not test on what #419 said, because Idk which item should I use. If anyone know which tool can break multiple blocks same time with specific direction please let me know.
Note: negative yaw means turn left, negative pitch means turn up