-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restriction: Adding "weaving-death-place" flag #4519
Merged
dordsor21
merged 7 commits into
IntellectualSites:main
from
RedstoneFuture:feature/weaving-death-place-flag
Nov 1, 2024
Merged
Restriction: Adding "weaving-death-place" flag #4519
dordsor21
merged 7 commits into
IntellectualSites:main
from
RedstoneFuture:feature/weaving-death-place-flag
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedstoneFuture
changed the title
Adding "weaving-death-place" flag
Restriction: Adding "weaving-death-place" flag
Oct 12, 2024
PierreSchwang
previously requested changes
Oct 12, 2024
Bukkit/src/main/java/com/plotsquared/bukkit/listener/EntityEventListener.java
Outdated
Show resolved
Hide resolved
Core/src/main/java/com/plotsquared/core/plot/flag/GlobalFlagContainer.java
Outdated
Show resolved
Hide resolved
Bukkit/src/main/java/com/plotsquared/bukkit/listener/EntityEventListener.java
Outdated
Show resolved
Hide resolved
Bukkit/src/main/java/com/plotsquared/bukkit/listener/EntityEventListener.java
Outdated
Show resolved
Hide resolved
Bukkit/src/main/java/com/plotsquared/bukkit/listener/EntityEventListener.java
Outdated
Show resolved
Hide resolved
SirYwell
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please also open a PR to add the flag to the documentation (https://github.com/IntellectualSites/documentation/blob/main/plotsquared/plot-flags.md). Thanks!
NotMyFault
approved these changes
Oct 20, 2024
PS-Flag documentation update: IntellectualSites/documentation#133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the "weaving-death-place" flag to prevent spawning of cobwebs on death by the Weaving status effect.
Fixes #4517
Description
false
)EntityChangeBlockEvent
The default value is “false”, because in my opinion it is rarely intended that the death of an entity on its own plot (including its own death) should spawn cobwebs on the plot (or other plots or the plot path). Especially because the status effect can be maintained by external factors (
minecraft:lingering_potion
). That makes the behavior so special that I wanted to handle it in a new custom flag rather than using an existing flag.Only since 1.21.x are there status effects that spawn or change blocks on death. I will expand the restriction of wind-charge in another PR to improve the restriction for the new 1.21 features / behaviors.
Submitter Checklist