Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restriction: Adding "weaving-death-place" flag #4519

Conversation

RedstoneFuture
Copy link
Member

@RedstoneFuture RedstoneFuture commented Oct 12, 2024

Overview

This PR adds the "weaving-death-place" flag to prevent spawning of cobwebs on death by the Weaving status effect.

Fixes #4517

Description

  • adding new flag "weaving-death-place" (default false)
  • adding checks in the EntityChangeBlockEvent

The default value is “false”, because in my opinion it is rarely intended that the death of an entity on its own plot (including its own death) should spawn cobwebs on the plot (or other plots or the plot path). Especially because the status effect can be maintained by external factors (minecraft:lingering_potion). That makes the behavior so special that I wanted to handle it in a new custom flag rather than using an existing flag.

Only since 1.21.x are there status effects that spawn or change blocks on death. I will expand the restriction of wind-charge in another PR to improve the restriction for the new 1.21 features / behaviors.

Submitter Checklist

@github-actions github-actions bot added the Feature This PR proposes a new feature label Oct 12, 2024
@RedstoneFuture RedstoneFuture changed the title Adding "weaving-death-place" flag Restriction: Adding "weaving-death-place" flag Oct 12, 2024
@RedstoneFuture RedstoneFuture marked this pull request as ready for review October 12, 2024 17:06
@RedstoneFuture RedstoneFuture requested a review from a team as a code owner October 12, 2024 17:06
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also open a PR to add the flag to the documentation (https://github.com/IntellectualSites/documentation/blob/main/plotsquared/plot-flags.md). Thanks!

@RedstoneFuture
Copy link
Member Author

PS-Flag documentation update: IntellectualSites/documentation#133

@dordsor21 dordsor21 merged commit 5e628cc into IntellectualSites:main Nov 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protection problem: Weaving status effect spawn blocks in roads and other plots
5 participants