Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: frost walker on untrusted plots #4230

Closed
wants to merge 1 commit into from
Closed

Fix: frost walker on untrusted plots #4230

wants to merge 1 commit into from

Conversation

ch4ika
Copy link
Contributor

@ch4ika ch4ika commented Nov 4, 2023

No description provided.

@ch4ika ch4ika requested a review from a team as a code owner November 4, 2023 20:03
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 4, 2023
@SirYwell
Copy link
Member

SirYwell commented Nov 4, 2023

I can't reproduce the issue. We already preventing what you describe two methods below via the ice-form flag. If you set that flag to true, players can form ice, as intended, but by default, that's not possible.

@ch4ika
Copy link
Contributor Author

ch4ika commented Nov 4, 2023

mb then

@ch4ika ch4ika closed this Nov 4, 2023
@Tamikaschu
Copy link
Contributor

Setting the flag ice-form to false would also disable ice forming because of the plotbiom. It doesnt affect the plotowner when wearing boots with frostwalker though.

@SirYwell
Copy link
Member

SirYwell commented Nov 5, 2023

I can see how you want this behavior to be more fine-granular. However, we're getting in the area of combinatorial explosion with that (we could add thousands of config options for things like that, and someone would still want something to work differently).

I think this is something that can be solved by a custom third-party plugin easily (i.e., you can basically use the code of this PR in your own plugin). This also allows to change behavior whenever you want, without breaking it for everyone else.

@ch4ika ch4ika deleted the frost-walker-fix branch December 14, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants