Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21.4 #3021

Merged
merged 6 commits into from
Dec 17, 2024
Merged

1.21.4 #3021

merged 6 commits into from
Dec 17, 2024

Conversation

PierreSchwang
Copy link
Member

Submitter Checklist

Preview Give feedback

@github-actions github-actions bot added the Feature This PR adds a new feature label Dec 7, 2024
@PierreSchwang
Copy link
Member Author

(seems like no changes to the adapter are required, at least none that I've noticed - but upstream created a new adapter as well, so I copied that)

@PierreSchwang
Copy link
Member Author

Spigot works so far as well, though there are weird chunk errors (partially only visible when getting to the actual section, leaving the section makes them invisible again) and some lighting issues. No error though, so idk if that's just Spigot being Spigot.

@PierreSchwang PierreSchwang marked this pull request as ready for review December 11, 2024 10:16
@PierreSchwang PierreSchwang requested a review from a team as a code owner December 11, 2024 10:16
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@PierreSchwang PierreSchwang requested a review from a team December 16, 2024 20:56
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested.

@NotMyFault NotMyFault merged commit 74bb6e3 into main Dec 17, 2024
11 checks passed
@NotMyFault NotMyFault deleted the feat/1.21.4 branch December 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants