Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware compatibility to device checking #8948

Merged

Conversation

remibettan
Copy link
Contributor

Tracked by: DSO-16958

@remibettan remibettan force-pushed the fw-update-version-sku-limitation branch 2 times, most recently from 0d3814b to 9e80864 Compare May 4, 2021 06:07
@remibettan remibettan changed the title checks for min version added for ds5 and l500 firmware compatibility to device checking May 4, 2021
@remibettan remibettan force-pushed the fw-update-version-sku-limitation branch 2 times, most recently from 3aca05a to 9647eb7 Compare May 11, 2021 11:18
@remibettan remibettan marked this pull request as ready for review May 18, 2021 11:38
@remibettan remibettan force-pushed the fw-update-version-sku-limitation branch from 1f4d925 to 476920d Compare May 18, 2021 11:41
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! minor fixes requred

common/fw-update-helper.cpp Outdated Show resolved Hide resolved
include/librealsense2/h/rs_device.h Outdated Show resolved Hide resolved
include/librealsense2/h/rs_device.h Outdated Show resolved Hide resolved
src/android/jni/device.cpp Show resolved Hide resolved
src/ds5/ds5-device.h Outdated Show resolved Hide resolved
src/usb/usb-types.h Show resolved Hide resolved
src/usb/usb-types.h Outdated Show resolved Hide resolved
@remibettan remibettan force-pushed the fw-update-version-sku-limitation branch from 476920d to 8492f46 Compare May 20, 2021 10:03
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@ev-mp ev-mp merged commit d10ebc2 into IntelRealSense:development May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants