Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4297 Multicamera IMU data mix up #5698

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Jan 23, 2020

HID devices now use the unique-ID assigned to their parent node (which is the USB node), letting them be properly associated with the proper composite device.

Multiple HID cameras should be identified correctly.
Addresses #4297
Tracked on: DSO-13711

@maloel maloel requested a review from dorodnic January 23, 2020 09:41
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic note - some MF/HID-allocated resources in Windows API must be explicitly released to prevent memleaks. Specifically things like BSTR and PROPVARIANT objects (PropVariantClear(&var))
Please run the routine in loop to verify this

Put Tracked on :DSO- num to the header

src/context.cpp Show resolved Hide resolved
src/win/win-helpers.cpp Show resolved Hide resolved
src/win/win-helpers.cpp Show resolved Hide resolved
src/win/win-helpers.cpp Show resolved Hide resolved
src/win/win-helpers.h Outdated Show resolved Hide resolved
* IntelRealSense#4297 Multicamera IMU data mix up
* Added Windows helper class surrounding Configuration Management nodes
* HID devices now use the unique-ID assigned to their parent node (which is the USB node)
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 88b3128 into IntelRealSense:development Feb 3, 2020
@maloel maloel deleted the hid branch February 13, 2020 12:10
icarpis pushed a commit to icarpis/librealsense that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants