Make save_single_frameset more robust #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lramati
commented
Sep 5, 2019
•
lramati
commented
- Save extrinsics between the frames in the saved frameset (for align, pointcloud, etc. post processing)
- Save depth units on depth frames (for e.g. get_distance)
lramati
changed the title
bernland
reviewed
Sep 6, 2019
There was a problem hiding this comment.
[https://github.com/lramati/librealsense/archive/ssfs.zip is the source for the below review.]
2D looks good:
3D with depth texture also works as expected:
However, there seems to be an issue using color texture in 3D mode:
Please let me know if there is anything I can do to assist.
|
The issue comes down to how Software Devices store the relationships between their sensors interfering with the recorder's ability to record the extrinsic relationships. Will take a while before a fix is implemented and this is ready to merge |
added 2 commits
September 11, 2019 17:45
…based on the environment's extrinsics graph. This allows extrinsics set using stream_profile.register_extrinsics_to() between streams on two different sensors on the same software_device to be visible to dev.get_extrinsics()
dorodnic
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.