Implement `dpnp.isin` #2595

ndgrigorian · 2025-09-25T18:26:42Z

This PR leverages the recently-added dpctl.tensor.isin to implement dpnp.isin

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

github-actions · 2025-09-25T18:51:22Z

View rendered docs @ https://intelpython.github.io/dpnp/pull/2595/index.html

github-actions · 2025-09-25T19:00:10Z

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_7 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

coveralls · 2025-09-25T19:04:03Z

coverage: 81.451% (+0.004%) from 81.447%
when pulling 42e9893 on reuse-tensor-isin
into 131c490 on master.

antonwolfy · 2025-10-09T12:33:18Z

dpnp/dpnp_iface_logic.py

    return a.flags.fnc


+def isin(element, test_elements, assume_unique=False, invert=False):


NumPy supports also kind keyword, but we can limit it with only None and 'sort' values and state a limitation that 'table' is not supported

Suggested change

def isin(element, test_elements, assume_unique=False, invert=False):

def isin(element, test_elements, assume_unique=False, invert=False, *, kind=None):

CuPy ignores this keyword though, which is why I chose to. I can add it in if you'd like, to be ignored like assume_unique

Yep, it'd be good to add.

dpnp/dpnp_iface_logic.py

antonwolfy · 2025-11-20T19:43:25Z

dpnp/dpnp_iface_logic.py

+        input arrays are unique. Included for compatibility with NumPy.
+        Default: ``False``.


We need to have an empty line before Default: .. to have it always from the new line in the rendered documentation:

Suggested change

input arrays are unique. Included for compatibility with NumPy.

Default: ``False``.

input arrays are unique. Included for compatibility with NumPy.

Default: ``False``.

antonwolfy · 2025-11-20T19:45:37Z

dpnp/dpnp_iface_logic.py

+        Default: ``False``.
+    invert : bool, optional
+        If ``True``, the values in the returned array are inverted, as if
+        calculating `element not in test_elements`.


To align with the form used at the top of the function description:

Suggested change

calculating `element not in test_elements`.

calculating ``element not in test_elements``.

antonwolfy · 2025-11-20T19:46:31Z

dpnp/dpnp_iface_logic.py

+        than) ``dpnp.invert(dpnp.isin(a, b))``.
+        Default: ``False``.


an empty line is missing:

Suggested change

than) ``dpnp.invert(dpnp.isin(a, b))``.

Default: ``False``.

than) ``dpnp.invert(dpnp.isin(a, b))``.

Default: ``False``.

antonwolfy · 2025-11-20T19:47:31Z

dpnp/dpnp_iface_logic.py

+
+

excess empty line:

Suggested change

antonwolfy · 2025-11-20T19:50:18Z

dpnp/dpnp_iface_logic.py

+
+    dpnp.check_supported_arrays_type(element, test_elements, scalar_type=True)
+    usm_element = dpnp.as_usm_ndarray(
+        element, usm_type=element.usm_type, sycl_queue=element.sycl_queue


element might be a scalar, but in that case test_elements is not scalar:

Suggested change

element, usm_type=element.usm_type, sycl_queue=element.sycl_queue

element, usm_type=test_elements.usm_type, sycl_queue=test_elements.sycl_queue

Or, alternatively, we need to calculate common SYCL queue and USM type somewhere above and pass here and to as_usm_ndarray below

antonwolfy · 2025-11-20T19:51:21Z

dpnp/tests/test_logic.py

+    assert_equal(result, expected)
+
+
+@pytest.mark.parametrize("dtype", get_all_dtypes())


Suggested change

@pytest.mark.parametrize("dtype", get_all_dtypes())

@pytest.mark.parametrize("dtype", get_all_dtypes(no_none=True))

antonwolfy · 2025-11-20T19:52:08Z

dpnp/tests/test_logic.py

    assert_equal(result, expected)
+
+
+@pytest.mark.parametrize(


It'd be great to have new tests placed inside a class TestIsin

antonwolfy · 2025-11-20T19:53:16Z

dpnp/tests/test_logic.py

    assert_equal(result, expected)
+
+
+@pytest.mark.parametrize(


CFD tests are missing, need to add one to test_sycl_queue.py and another to test_usm_type.py

ndgrigorian force-pushed the reuse-tensor-isin branch from de4e3bb to df81181 Compare September 25, 2025 18:29

antonwolfy added this to the 0.20.0 release milestone Oct 7, 2025

antonwolfy reviewed Oct 9, 2025

View reviewed changes

ndgrigorian added 2 commits November 19, 2025 15:39

Implement dpnp.isin

a980c7f

unskip cupy isin tests

086f9c7

ndgrigorian force-pushed the reuse-tensor-isin branch from df81181 to 0b51fa3 Compare November 20, 2025 03:04

ndgrigorian added 2 commits November 19, 2025 19:08

address review comments

9e67af0

add to assume_unique documentation

92f5ae5

ndgrigorian force-pushed the reuse-tensor-isin branch 4 times, most recently from 07f280b to 7d29652 Compare November 20, 2025 03:16

ndgrigorian added 2 commits November 19, 2025 19:47

add isin tests

c5aff44

disable pylint for isin unused assume_unique argument

42e9893

ndgrigorian force-pushed the reuse-tensor-isin branch from 7d29652 to 42e9893 Compare November 20, 2025 03:47

ndgrigorian marked this pull request as ready for review November 20, 2025 04:32

ndgrigorian requested a review from vlad-perevezentsev as a code owner November 20, 2025 04:32

ndgrigorian requested a review from antonwolfy November 20, 2025 04:32

antonwolfy reviewed Nov 20, 2025

View reviewed changes

		return a.flags.fnc


		def isin(element, test_elements, assume_unique=False, invert=False):

		input arrays are unique. Included for compatibility with NumPy.
		Default: ``False``.

	calculating `element not in test_elements`.
	calculating ``element not in test_elements``.

	element, usm_type=element.usm_type, sycl_queue=element.sycl_queue
	element, usm_type=test_elements.usm_type, sycl_queue=test_elements.sycl_queue

		assert_equal(result, expected)


		@pytest.mark.parametrize("dtype", get_all_dtypes())

Implement dpnp.isin #2595

Are you sure you want to change the base?

Implement dpnp.isin #2595

Conversation

ndgrigorian commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implement `dpnp.isin` #2595

Implement `dpnp.isin` #2595

github-actions bot commented Sep 25, 2025 •

edited

Loading

coveralls commented Sep 25, 2025 •

edited

Loading