Skip to content

Remove use of python setup.py develop/install in the project #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove use of python setup.py develop/install in the project #2172

wants to merge 5 commits into from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Oct 15, 2025 •
edited
Loading

A warning that python setup.py develop is deprecated and will no longer be supported at the end of October, 2025 has been ongoing for some time when using dpctl build driver script, and can be seen in the CI

This PR proposes instead relying on pip for installing dpctl in the script, and reworks the script to maintain use of scikit-build

In the future, this will also simplify a transition to scikit-build-core

The PR also introduces options

  • --clean and --skip-editable to build_locally driver
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the do-not-use-setup-py-develop branch from 6d87c72 to 124f5f7 Compare October 15, 2025 00:34
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/2172/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_29 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_29 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Oct 15, 2025 •
edited
Loading

Coverage Status

coverage: 85.264%. remained the same
when pulling 0648317 on do-not-use-setup-py-develop
into 909ab6d on master.

@ndgrigorian ndgrigorian force-pushed the do-not-use-setup-py-develop branch 2 times, most recently from fd45fec to 13409b7 Compare October 15, 2025 05:18
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@ndgrigorian
refactor common build functionality out into separate file
32f1509 
to be reused in gen_docs and gen_coverage
@ndgrigorian ndgrigorian force-pushed the do-not-use-setup-py-develop branch from 13409b7 to 32f1509 Compare October 15, 2025 05:42
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian changed the title Do not use python setup.py develop in the project Remove use of python setup.py develop/install in the project Oct 15, 2025
antonwolfy
antonwolfy reviewed Oct 15, 2025
View reviewed changes
scripts/build_locally.py
p.add_argument(
"--debug",
default="Release",
dest="build_type",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug build produces a lot of the warning which probably has to be resolved in the follow-up PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a number of them are
icpx: warning: argument unused during compilation: '-Xsycl-target-frontend=spir64 -g0'
which will need some looking at

the remainder are
warning: comparison of integers of different signs: 'py::ssize_t' (aka 'long') and 'std::size_t'
from
assert(dst.get_size() == iter_nelems)
in sorting functions

should be a simple enough fix

@ndgrigorian ndgrigorian force-pushed the do-not-use-setup-py-develop branch from 00161f1 to 989df1b Compare October 15, 2025 15:40
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_32 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_31 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_32 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy