setup.py for building C++ backend #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PokhodenkoSA
suggested changes
Nov 5, 2020
added 2 commits
November 5, 2020 04:48
Contributor
|
I thought this PR would build on Python's interface to CMake: https://github.com/pytorch/pytorch/blob/master/tools/build_pytorch_libs.py#L51 Kind of like Maybe a little too heavy-handed for our purposes. |
Contributor
|
Tested locally on Linux: OK.
|
added 2 commits
November 12, 2020 02:39
Contributor
|
@1e-to, please, update README. |
PokhodenkoSA
approved these changes
Nov 12, 2020
PokhodenkoSA
approved these changes
Nov 12, 2020
PokhodenkoSA
approved these changes
Nov 12, 2020
Contributor
PokhodenkoSA
left a comment
PokhodenkoSA
left a comment
There was a problem hiding this comment.
Thanks @1e-to. LGTM. Could be merged after CI finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must resolve the problem from this issue #145.