setup.py for building C++ backend (WIP)#153
Closed
1e-to wants to merge 3 commits into
Closed
Conversation
1e-to
changed the title
diptorupd
reviewed
Oct 30, 2020
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
Looking forward to getting this is merged.
| os.environ["CC"] = "clang" | ||
| os.environ["CXX"] = "clang++" | ||
| else: | ||
| print("DPCPP is needed to build DPPL. Abort!") |
| # "-DCMAKE_INSTALL_PREFIX=" + INSTALL_PREFIX, | ||
| # "-DCMAKE_PREFIX_PATH=" + INSTALL_PREFIX, | ||
| # "-DDPCPP_ROOT=" + DPCPP_ROOT, | ||
| # "-DPYTHON_INCLUDE_DIR=" + PYTHON_INC, |
Contributor
There was a problem hiding this comment.
Please check the latest build_for_develop.sh I removed PYTHON_INC and NUMPY__INC as these are not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR must resolve the problem from this issue #145.