Extra device info #147
Merged
Extra device info #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2020 10:22
Contributor
|
Linux CI fails. |
diptorupd
reviewed
Oct 21, 2020
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
Looking good. Needs some minor clean ups and should be ready.
diptorupd
approved these changes
Oct 22, 2020
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
Looks very good. Please fix the one small naming change in C++ test case and it is good to go. Thanks!
| { | ||
| DPPLSyclDeviceRef OpenCL_cpu = nullptr; | ||
| DPPLSyclDeviceRef OpenCL_gpu = nullptr; | ||
| DPPLSyclDeviceRef OpenCL_level_zero = nullptr; |
Contributor
There was a problem hiding this comment.
Call it Level0_gpu. OpenCl and Level0 are different driver stacks for the same GPU device.
Contributor
|
@1e-to please rebase with master and I can merge it tomorrow. |
added 2 commits
October 23, 2020 03:44
| return D->is_cpu(); | ||
| } | ||
| return false; | ||
|
|
| return D->get_info<info::device::max_compute_units>(); | ||
| } | ||
| return 0; | ||
|
|
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #113 and closes #81.