Skip to content

Remove OpenCL interface #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diptorupd merged 8 commits into from
Oct 23, 2020
Merged

Remove OpenCL interface #138

diptorupd merged 8 commits into from
Oct 23, 2020

Conversation

@1e-to
Copy link
Contributor

@1e-to 1e-to commented Oct 15, 2020 •
edited by PokhodenkoSA
Loading

This PR closes #106

diptorupd
diptorupd reviewed Oct 18, 2020
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cffi is no longer needed once ocldrv is removed, so meta.yaml should also be changed. Apart from that looks fine. Please make sure CI passes on both Windows and Linux.

@PokhodenkoSA PokhodenkoSA mentioned this pull request Oct 19, 2020
Closed
32 tasks
PokhodenkoSA
PokhodenkoSA approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As CI passed last time it LGTM.
I expect some things are not cleared but I can not list all it now.
I will merge if CI pass after my update of README.

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Oct 20, 2020

I would like CHANGE_LOG to be updated too.

@diptorupd
Copy link
Contributor

diptorupd commented Oct 23, 2020

I tested it locally and things looked ok. Tested both $scripts/build_for_develop.sh and conda build conda-recipe.

@diptorupd diptorupd merged commit d8e7104 into IntelPython:master Oct 23, 2020
@1e-to 1e-to deleted the remove_opencl_interface branch March 2, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@diptorupd diptorupd diptorupd left review comments

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@1e-to 1e-to

Labels

None yet

Projects

None yet

Milestone

gold

Development

Successfully merging this pull request may close these issues.

Remove dppl_opencl_interface.{h|c}, ocldrv.py, opencl_core.py

3 participants

@1e-to @PokhodenkoSA @diptorupd