Feature/get ref address #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- default device is alayws available.
Contributor
Author
|
@PokhodenkoSA can be merged once CI completes. @reazulhoque Please note the name change for the functions. |
PokhodenkoSA
approved these changes
Oct 6, 2020
Contributor
PokhodenkoSA
left a comment
PokhodenkoSA
left a comment
There was a problem hiding this comment.
LGTM. Will merge it.
| The address of the DPPLSyclProgramRef object used to create this | ||
| SyclProgram cast to a long. | ||
| """ | ||
| return int(<long>self._program_ref) |
Contributor
There was a problem hiding this comment.
Long is not good here. It is a 32-bit integer on Windows. We should be using <size_t> instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR reworks #87 to use the same name
addressof_reffor all classes that wrap DPPLSyclxxxx objects. Added docstring.The change is needed because inside Numba we are directly calling dpctl's C API during LLVM lowering for kernel submit call. Having these convenience functions lets us get the address of the DPPLSyclKernelRef from a SyclKernel Python object.
To standardize the API the same
addressof_refcall was added for all classes.