Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent_launch_files_arg #198

Merged
merged 2 commits into from
Oct 1, 2024
Merged

consistent_launch_files_arg #198

merged 2 commits into from
Oct 1, 2024

Conversation

Nikhil-Singhal-06
Copy link
Collaborator

Description

true false consistency in launch files.

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Test Results

357 tests   349 ✅  40m 44s ⏱️
 16 suites    8 💤
 16 files      0 ❌

Results for commit de504fa.

♻️ This comment has been updated with latest results.

@fred-labs fred-labs merged commit 1d35fd6 into main Oct 1, 2024
28 checks passed
@fred-labs fred-labs deleted the launch_files_cleanup branch October 1, 2024 10:40
fred-labs pushed a commit that referenced this pull request Oct 2, 2024
@Nikhil-Singhal-06 @fred-labs
consistent_launch_files_arg (#198)
e6c2d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred-labs fred-labs fred-labs approved these changes

@fmirus fmirus Awaiting requested review from fmirus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikhil-Singhal-06 @fred-labs