Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish behavior tree by default, update clients #111

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Publish behavior tree by default, update clients #111

merged 6 commits into from
Jul 16, 2024

Conversation

fred-labs
Copy link
Contributor

@fred-labs fred-labs commented Jul 15, 2024 •
edited
Loading

Description

Instead of requesting a behavior tree snapshot publisher for every client, enable one by default. This can be used by e.g. clients or within a ros-bag

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Test Results

236 tests   222 ✅  22m 58s ⏱️
 14 suites   14 💤
 14 files      0 ❌

Results for commit ccb79ac.

♻️ This comment has been updated with latest results.

@fred-labs fred-labs marked this pull request as ready for review July 15, 2024 12:27
@fred-labs fred-labs requested review from Nikhil-Singhal-06 and fmirus and removed request for Nikhil-Singhal-06 July 15, 2024 12:27
fmirus
fmirus requested changes Jul 16, 2024
View reviewed changes
docs/libraries.rst Outdated Show resolved Hide resolved
simulation/gazebo/tb4_sim_scenario/launch/ignition_launch.py Show resolved Hide resolved
scenario_execution_rviz/src/scenario_view.cpp Show resolved Hide resolved
@fred-labs fred-labs enabled auto-merge (squash) July 16, 2024 08:39
@fred-labs fred-labs merged commit 788ff88 into main Jul 16, 2024
24 checks passed
@fred-labs fred-labs deleted the bt_snapshot branch July 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred-labs @fmirus