Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for Modifiers #110

Merged
merged 39 commits into from
Jul 17, 2024
Merged

Add basic support for Modifiers #110

merged 39 commits into from
Jul 17, 2024

Conversation

fred-labs
Copy link
Contributor

@fred-labs fred-labs commented Jul 9, 2024 •
edited
Loading

Description

Modifiers as defined in OpenScenario2 are now mapped py-trees decorators.
For now only a fixed list of modifiers is supported:

  • repeat
  • inverter
  • timeout
  • retry

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Test Results

258 tests   244 ✅  35m 20s ⏱️
 14 suites   14 💤
 14 files      0 ❌

Results for commit 2109000.

♻️ This comment has been updated with latest results.

@fred-labs fred-labs marked this pull request as ready for review July 10, 2024 07:55
@fred-labs fred-labs enabled auto-merge (squash) July 10, 2024 07:55
@fred-labs fred-labs requested a review from fmirus July 10, 2024 07:55
fmirus
fmirus requested changes Jul 10, 2024
View reviewed changes
scenario_execution/scenario_execution/lib_osc/helpers.osc Outdated Show resolved Hide resolved
docs/tutorials.rst Outdated Show resolved Hide resolved
examples/example_multi_robot/example_multi_robot.osc Outdated Show resolved Hide resolved
scenario_coverage/scenarios/test_fault_injection_drop.osc Show resolved Hide resolved
scenario_coverage/scenarios/test_nav_to_pose.osc Outdated Show resolved Hide resolved
@fred-labs fred-labs merged commit 286a546 into main Jul 17, 2024
24 checks passed
@fred-labs fred-labs deleted the composite_modifier branch July 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred-labs @fmirus