Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_lifecycle_state: update parameter #107

Merged
merged 11 commits into from
Jul 8, 2024
Merged

assert_lifecycle_state: update parameter #107

merged 11 commits into from
Jul 8, 2024

Conversation

fred-labs
Copy link
Contributor

@fred-labs fred-labs commented Jul 5, 2024 •
edited
Loading

Description

Update parameters

  • rename fail_on_finish to fail_on_unexpected
  • add keep_running

Other changes:

  • fixes in check_data
  • change parameter order in actions: move qos_profile to the end

@fred-labs fred-labs changed the title assert_lifecycle_state: Add parameter assert_lifecycle_state: update parameter Jul 5, 2024
@fred-labs fred-labs marked this pull request as ready for review July 5, 2024 11:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

Test Results

236 tests   222 ✅  27m 41s ⏱️
 14 suites   14 💤
 14 files      0 ❌

Results for commit 0797252.

♻️ This comment has been updated with latest results.

@fred-labs fred-labs requested a review from fmirus July 8, 2024 06:36
@fred-labs fred-labs merged commit 217146f into main Jul 8, 2024
24 checks passed
@fred-labs fred-labs deleted the update_assert_state_check branch July 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred-labs @fmirus