cpu affinity: consider --cpu-offset as override to auto-detection #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --cpu-offset arugment was incompatible with automated detection of free/busy CPUs. The reduced cpu set is not obvious during startup time and we may fail to launch workers if cpu set + cpu offset < workers. This patch disables auto-detection of free vcpus if a --cpu-offset is given. This restores the original semantics of --cpu-offset.
Wenzel
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --cpu-offset arugment was incompatible with automated detection of free/busy CPUs. The reduced cpu set is not obvious during startup time and we may fail to launch workers if cpu set + cpu offset < workers.
This patch disables auto-detection of free vcpus if a --cpu-offset is given. This restores the original semantics of --cpu-offset.