-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Adds missing dependency: faker #960
Conversation
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DemoApp
participant Faker
User->>DemoApp: Request for demo data
DemoApp->>Faker: Generate fake data
Faker-->>DemoApp: Return fake data
DemoApp-->>User: Provide demo data
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@uzyn I'm surprised you're running into this issue, I just tried again deleting all node modules, re-installing and running the command, and it's not failing on my end. I wonder if this is an env-specific issue, could you paste the node version you're running? |
Could it be that you have faker installed globally? I'm on node v20.16.0 Here's the full log from a newly fresh clone of hyperview: $ git clone [email protected]:Instawork/hyperview.git
Cloning into 'hyperview'...
remote: Enumerating objects: 21548, done.
remote: Counting objects: 100% (5708/5708), done.
remote: Compressing objects: 100% (2060/2060), done.
remote: Total 21548 (delta 3220), reused 5027 (delta 2885), pack-reused 15840 (from 1)
Receiving objects: 100% (21548/21548), 39.18 MiB | 6.70 MiB/s, done.
Resolving deltas: 100% (12547/12547), done.
$ cd hyperview/demo
$ node -v
v20.16.0
$ yarn server
yarn run v1.22.22
$ eleventy --serve --port=8085
/bin/sh: eleventy: command not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
$ yarn
yarn install v1.22.22
[1/4] 🔍 Resolving packages...
warning Resolution field "@typescript-eslint/[email protected]" is incompatible with requested version "@typescript-eslint/[email protected]"
warning Resolution field "@typescript-eslint/[email protected]" is incompatible with requested version "@typescript-eslint/[email protected]"
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " > [email protected]" has incorrect peer dependency "react@^17.0.2".
warning " > [email protected]" has incorrect peer dependency "react-native@^0.67.4".
warning " > [email protected]" has incorrect peer dependency "[email protected]".
[4/4] 🔨 Building fresh packages...
✨ Done in 7.79s.
$ yarn server
yarn run v1.22.22
$ eleventy --serve --port=8085
[11ty] Cannot find module '@faker-js/faker'
[11ty] Require stack:
[11ty] - /path/to/hyperview/demo/backend/_data/contacts.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/src/TemplateData.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/src/Eleventy.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/cmd.js (via Error)
[11ty]
[11ty] Original error stack trace: Error: Cannot find module '@faker-js/faker'
[11ty] Require stack:
[11ty] - /path/to/hyperview/demo/backend/_data/contacts.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/src/TemplateData.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/src/Eleventy.js
[11ty] - /path/to/hyperview/demo/node_modules/@11ty/eleventy/cmd.js
[11ty] at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
[11ty] at Module._load (node:internal/modules/cjs/loader:986:27)
[11ty] at Module.require (node:internal/modules/cjs/loader:1233:19)
[11ty] at require (node:internal/modules/helpers:179:18)
[11ty] at Object.<anonymous> (/path/to/hyperview/demo/backend/_data/contacts.js:1:19)
[11ty] at Module._compile (node:internal/modules/cjs/loader:1358:14)
[11ty] at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
[11ty] at Module.load (node:internal/modules/cjs/loader:1208:32)
[11ty] at Module._load (node:internal/modules/cjs/loader:1024:12)
[11ty] at Module.require (node:internal/modules/cjs/loader:1233:19)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
Ok I see what went wrong, it's installed as part of hyperview package, but I recently moved some of 11ty deps to the demo package but forgot to move this one. Thanks for the PR! |
Otherwise demo would not run:
Summary by CodeRabbit