Sync with upstream master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outdated. Only add ISRs that the cluster is aware of to avoid KeyErrors here. Inconsistencies will be automatically resolved when `Cluster.update` is called. The error happens in following use case: 1. KafkaClient is initiated (and thus Cluster is also initiated with cluster's metadata) 2. New brokers has been added to Kafka's cluster and ISRs of some partitions has been rebalanced 3. Try to access a topic using the client object created in step 1 - It **FAILS** because one of the ISRs is in new broker that this client is not aware of yet
`LeaderNotFoundError` while initiating a `Topic` object
Bumps [pytest](https://github.com/pytest-dev/pytest) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@4.4.0...4.4.1) Signed-off-by: dependabot[bot] <[email protected]>
Bump pytest from 4.4.0 to 4.4.1
Improve stability in cases of new broker additions to cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.