Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use the latest LibCST source code in Pyre check #262

Merged

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Mar 11, 2020

Summary

After we ask pyre to read site-packages, Pyre cannot understand new changes in LibCST repo..
CI installs pyre-check from pip requirements which installs the public version of libcst.
This removes the installed libcst and install from the checked out repo.

Test Plan

CI build.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2020
@jimmylai jimmylai force-pushed the ci_use_libcst_source_in_pyre_check branch 4 times, most recently from 067c42b to 65dfe0b Compare March 11, 2020 15:57
@jimmylai jimmylai requested a review from thatch March 11, 2020 16:00
@jimmylai jimmylai force-pushed the ci_use_libcst_source_in_pyre_check branch 2 times, most recently from 2208d0e to accc06f Compare March 11, 2020 16:07
@jimmylai jimmylai requested a review from zsol March 11, 2020 16:08
@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         214      214           
  Lines       20818    20818           
=======================================
  Hits        19546    19546           
  Misses       1272     1272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d2679...993e211. Read the comment docs.

@thatch
Copy link
Contributor

thatch commented Mar 11, 2020

Can you rename .pyre_configuration to .pyre_configuration.sample or so, now that it's ignored? (The circleci doesn't need to save and restore then, just delete the copy after running.)

@jimmylai jimmylai force-pushed the ci_use_libcst_source_in_pyre_check branch from accc06f to 993e211 Compare March 12, 2020 03:31
@jimmylai
Copy link
Contributor Author

@thatch Renamed .pyre_configuration as .pyre_configuration.example and updated the README accordingly.

@jimmylai jimmylai merged commit ea8619a into Instagram:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants