Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: merge private-views package into mono-repo #527

Open
wants to merge 43 commits into
base: refactor/monorepo
Choose a base branch
from

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  1. merge private-views package into mono-repo

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID : MOB-16296

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 2, 2024

Warnings
⚠️

Coverage for instabug_private_views is less than the expected threshold of 80%

Coverage Report

Label Coverage Status
instabug_flutter 80.4%
instabug_private_views 73.6%

Generated by 🚫 dangerJS against be76a07

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Nov 3, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug requested review from AndrewAminInstabug and a7medev and removed request for AndrewAminInstabug November 3, 2024 23:20
@ahmedAlaaInstabug ahmedAlaaInstabug marked this pull request as ready for review November 3, 2024 23:21
@ahmedAlaaInstabug ahmedAlaaInstabug force-pushed the refactor/monorepo-private-view-package branch from a6e58fc to 38971ab Compare November 10, 2024 15:01
…into refactor/monorepo-private-view-package

# Conflicts:
#	packages/instabug_flutter/android/build.gradle
#	packages/instabug_flutter/android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
#	packages/instabug_flutter/android/src/test/java/com/instabug/flutter/InstabugApiTest.java
#	packages/instabug_flutter/example/ios/Podfile.lock
#	packages/instabug_flutter/ios/Classes/Modules/InstabugApi.m
#	scripts/init.sh
…rivate-view-package-test' into refactor/monorepo-private-view-package

# Conflicts:
#	packages/instabug_private_views/lib/src/instabug_private_view.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants