Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: merge modular package into mono-repo #522

Open
wants to merge 8 commits into
base: refactor/monorepo
Choose a base branch
from
Open

Refactor: merge modular package into mono-repo #522

wants to merge 8 commits into from

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  • add modular plugin to mono-repo

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID : MOB-16295

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to refactor/monorepo October 21, 2024 15:51
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Refactor: add modular plugin to mono-repo Refactor: merge modular plugin into mono-repo Oct 21, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Refactor: merge modular plugin into mono-repo Refactor: merge modular package into mono-repo Oct 21, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Oct 21, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
instabug_flutter 80.4% ✅
instabug_flutter_modular 91.2% ✅

Generated by 🚫 dangerJS against 0f1c65a

@ahmedAlaaInstabug ahmedAlaaInstabug marked this pull request as ready for review October 23, 2024 21:15
a7medev
a7medev requested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ahmedAlaaInstabug! I have a small comment and we'd be good to go 🙏🏼
Let's also make sure that the CI is green 🙏🏼

.circleci/config.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

@a7medev a7medev Awaiting requested review from a7medev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedAlaaInstabug @InstabugCI @a7medev @AndrewAminInstabug