feat: support masking private views #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedAlaaInstabug
requested review from
kholood-ea,
a7medev,
AndrewAminInstabug and
AyaMahmoud148
a7medev
requested changes
Oct 17, 2024
android/src/main/java/com/instabug/flutter/util/privateViews/PixelCopyManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/util/privateViews/PrivateViewManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/util/privateViews/PrivateViewManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/util/privateViews/PrivateViewManager.java
Outdated
Show resolved
Hide resolved
Comment on lines
+122
to
+127
| internalCore._setScreenshotCaptor(new ScreenshotCaptor() { | ||
| @Override | ||
| public void capture(@NonNull ScreenshotRequest screenshotRequest) { | ||
| privateViewManager.mask(screenshotRequest.getListener()); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I see the privateViewManager frequently switching to the main thread through ThreadManager.runOnMainThread, are there possibilities of the screenshot captor being called on a background thread?
There was a problem hiding this comment.
noo,, access flutter view need to be on the main thread
a7medev
previously approved these changes
Oct 31, 2024
a7medev
changed the title
a7medev
changed the title
* feat: add private view page * fix private view screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
JIRA ID: MOB-16098
Checklists
Development
Code review