Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android showSurvey ANR #430

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: android showSurvey ANR #430

wants to merge 3 commits into from

Conversation

abdelhamid-f-nasser
Copy link
Contributor

Description of the change

Modify the Surveys.showSurvey to call the newly added private Android SDK API SurveysshowSurveyCP. This ensures that the showSurvey is called on the background thread by default eliminating any ANRs from occurring.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira IDs:

  • INSD-10685
  • MOB-13622

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft January 10, 2024 10:17
@abdelhamid-f-nasser abdelhamid-f-nasser added the pending-android Waiting for Android release label Jan 10, 2024
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against 45ab27f

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/android-showSurvey-ANR branch from c86e3c2 to 45ab27f Compare January 10, 2024 10:58
Base automatically changed from dev to master February 15, 2024 12:32
@stale stale bot removed the Pending Feedback label Mar 6, 2024
@abdelhamid-f-nasser
fix(android): Resolve ANR in showSurvey
7f15ed9 
This fix addresses the ANR issue in the `showSurvey` function on Android. The resolution ensures smoother execution by defaulting it to the background thread.
@abdelhamid-f-nasser
docs: update changelog.md
c65d4b7
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/android-showSurvey-ANR branch from 45ab27f to c65d4b7 Compare March 6, 2024 07:42
@mnoseir
Copy link

mnoseir commented Mar 6, 2024

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against 664a600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending-android Waiting for Android release Requires Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelhamid-f-nasser @InstabugCI @mnoseir