Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12122] Integrate Danger Coverage Plugin #357

Merged
merged 7 commits into from
May 1, 2023
Merged

[MOB-12122] Integrate Danger Coverage Plugin #357

merged 7 commits into from
May 1, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Apr 12, 2023

Description of the change

Integrates the repo with the new Danger code coverage plugin for visibility on code coverage on PRs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Apr 12, 2023
@a7medev a7medev force-pushed the ci/integrate-danger-coverage branch 2 times, most recently from 31be62e to baeba78 Compare April 12, 2023 18:39
@InstabugCI
Copy link
Collaborator

InstabugCI commented Apr 12, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 83.7% ✅

Generated by 🚫 dangerJS against 4f62000

@a7medev a7medev requested a review from DavidMina96 April 12, 2023 18:57
@a7medev a7medev changed the base branch from master to dev April 13, 2023 09:58
Base automatically changed from dev to master April 17, 2023 13:36
@a7medev a7medev force-pushed the ci/integrate-danger-coverage branch from 8290040 to 4f62000 Compare April 20, 2023 10:28
@a7medev a7medev changed the base branch from master to dev April 20, 2023 10:29
@a7medev a7medev merged commit 33b15da into dev May 1, 2023
@a7medev a7medev deleted the ci/integrate-danger-coverage branch May 1, 2023 07:40
HeshamMegid pushed a commit that referenced this pull request May 30, 2023
@a7medev @HeshamMegid
[MOB-12122] Integrate Danger Coverage Plugin (#357)
40f3ca3 
* Migrate Danger to TypeScript

* Integrate Danger coverage plugin

* Exclude generated files from coverage

* Set Yarn network concurrency to 1

* Remove LCOV installation

* Add TypeScript

* Add coverage threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @DavidMina96