Skip to content

Conversation

@tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Sep 26, 2022

No description provided.

@tbirdso tbirdso requested review from dzenanz and thewtex September 26, 2022 14:33
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CI failures expected?

@tbirdso
Copy link
Contributor Author

tbirdso commented Sep 26, 2022

Not expected. I see v5.3rc04.post3 builds at https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/tag/v5.3rc04.post3 as expected but it seems like the archive is not extracted properly after download? Will need to investigate.

@tbirdso
Copy link
Contributor Author

tbirdso commented Oct 4, 2022

CI is now passing 🟢

@dzenanz
Copy link
Member

dzenanz commented Oct 5, 2022

Will this recipe fix InsightSoftwareConsortium/ITKModuleTemplate#133? If so, that will allow getting InsightSoftwareConsortium/ITKModuleTemplate#134 through, so I can get it off my mind.

@tbirdso
Copy link
Contributor Author

tbirdso commented Oct 5, 2022

@dzenanz I will follow up in that issue. I am not sure that the failure in #134 is the exact same cause as it looks like it is failing to find gcc. Let's implement the ITK bump and follow up from there.

@tbirdso tbirdso merged commit c635466 into InsightSoftwareConsortium:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants