COMP: Update binder matplotlib #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And monain and itk-elastix to be consistent with examples/requirements.txt. To address binder build where matplotlib fails to build from source. Similar to #359 Update the matplotlib version so pre-built packages are available.
N-Dekker
reviewed
Dec 15, 2025
| @@ -1,13 +1,13 @@ | |||
| itk-elastix>=0.17.3 | |||
| itk-elastix>=0.19.1 | |||
Collaborator
There was a problem hiding this comment.
Thanks Matt, cool!
Would it be an idea to simply just require the latest version of itk-elastix? (Which is now 0.23.0.)
N-Dekker
approved these changes
Dec 16, 2025
Collaborator
N-Dekker
left a comment
N-Dekker
left a comment
There was a problem hiding this comment.
Thanks Matt, approved 👍, but please let me know what you think about the idea to simply just require the latest version of itk-elastix (0.23.0)!
Member
Author
|
@N-Dekker thanks for the review! Good idea updating the version -- I pushed a commit for both Binder and the examples. |
Collaborator
|
Thanks for fixing Matt!
Kind regards,
Prof. dr. ir. Stefan Klein
Professor of Applied Medical Image Analysis
General Chair of Biomedical Imaging Group Rotterdam (BIGR)
Dept. of Radiology & Nuclear Medicine
***@***.***
+31 10 7043442<tel:+31%2010%207043442>
Van: Niels Dekker ***@***.***>
Verzonden: maandag 15 december 2025 22:22
Aan: InsightSoftwareConsortium/ITKElastix ***@***.***>
CC: Stefan Klein ***@***.***>; Review requested ***@***.***>
Onderwerp: Re: [InsightSoftwareConsortium/ITKElastix] COMP: Update binder matplotlib (PR #361)
Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is.
Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@N-Dekker commented on this pull request.
…________________________________
In .binder/requirements.txt<#361 (comment)>:
@@ -1,13 +1,13 @@
-itk-elastix>=0.17.3
+itk-elastix>=0.19.1
Thanks Matt, cool!
Would it be an idea to simply just require the latest version of itk-elastix? (Which is now 0.23.0.)
-
Reply to this email directly, view it on GitHub<#361 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAF2LNN7ORFTOVOEMBGJUET4B4Q7PAVCNFSM6AAAAACPDYI246VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBQGIYDSMJSGU>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And monai and itk-elastix to be consistent with
examples/requirements.txt.
To address binder build where matplotlib fails to build from source. Similar to #359 Update the matplotlib version so pre-built packages are available.