Update to ubuntu 24.04 and clang-format 18#3
Closed
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
Update to ubuntu 24.04 and clang-format 18#3blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Member
Author
|
Currently the actions are just referring to "master". I am not sure how multiple versions can/should be supported. |
2 tasks
Member
|
With ITKv6 development started, maybe it is time for this and InsightSoftwareConsortium/ITK#3805 to move forward? |
Member
|
We can get the same version of clang-format used with ITK's clang-format configuration and pre-commit with: |
Member
|
@thewtex I created a PR taking a different approach than what you suggest. I think your suggestion is likely more flexible. Would you mind pushing this forward? clang-format github action tests are adding the the burden of keeping the remote modules up-to-date. |
Member
|
@blowekamp See #7 as an update. I think @thewtex suggestion is probably better to exactly match what is used in ITK. |
Member
|
Superseded by #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.