STYLE: Rename remote module maintenance script#664
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 31, 2019
Merged
Conversation
Rename remote module maintenance script to better reflect its purpose.
jhlegarreta
added
type:Infrastructure
Member
Author
|
As requested in #658 (comment). @thewtex I added a trailing s at the end of the filename. As said in a previous PR, at some point in time, the script will go over all remote modules and make the changes without requiring the paths as input parameters. Please let me know if you still think the singular name is more appropriate. |
8 tasks
dzenanz
approved these changes
Mar 31, 2019
Member
|
Awesome, thanks @jhlegarreta ! Looks good -- the more specific Remote over Files should help new contributors apply the script :-) |
blowekamp
pushed a commit
to blowekamp/ITK
that referenced
this pull request
Nov 17, 2019
Run the UpdateFromUpstream.sh script to extract upstream VNL
using the following shell commands.
$ git archive --prefix=upstream-vnl/ 42ff8459 --
CMakeLists.txt
config/cmake
core/CMakeLists.txt
core/testlib
core/vnl
core/vxl_config.h.in
core/vxl_copyright.h
core/vxl_version.h
v3p/CMakeLists.txt
v3p/netlib
vcl
| tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 7cc97a62..42ff8459
Bradley Lowekamp (1):
69fbbe90 COMP: Address unused parameter in defaulted methods warning
Chris Johnson (2):
16071b5c Fix failing build
c774959e Fix compiler error
Cynthia Lucock (7):
3ce6a5f1 corrected rounding and tested for NaN in bsgm
8f235198 deleted -0.5 from rounding and got rid of signbit
36c8d126 corrected use of isnan to std::isnan
f7b66275 brl fixed new unreferenced local variable warnings
2606874a fixed warnings signed/unsigned mismatch in brl
d0438a98 fixed warnings type cast pointer truncation in brl
5ab68c93 fixed type warnings in vgui_range_map
Daniel Crispell (2):
d80d07b8 BUG: regularize solution to improve stability of linear interpolation
42ff8459 COMP: fix various compiler errors in contrib (Apple clang version 11.0.0)
Drew Gilliam (38):
361f4d4c for travisci, add --output-on-failure flag to ctest to report full test failures
4ef3f129 move vnl_random to header file in bvgl_register_ptsets_3d_rigid
dc9dc29b disable (again) failing tests in betr
70cfa05c remove failing test (contrib/mul/vimt/tests/test_v2i)
405aab16 add initializer_list for vpgl_rational_order to permit easy iteration over enum values
52df64be increment version to 2.0.2.2
edd75431 vpgl_rational_order tests
2d30f5a0 travis update - switch to ninja, enable build caching
cec6ab29 disable travis cache
64ba44d2 travis CI update: - fix caching bug (accidental caching of source that overwrote new git checkout) - improve coverage with multiple gcc versions - full build on all pull requests & cron jobs
ded04ace missing stdexcept header in vul_string.cxx (issue for gcc 4.9.4)
4dfc42cb swap recently added 'm_LetArrayManageMemory' member variable for vnl_matrix and vnl_vector
3575dfd6 more swap tests for vnl_vector and vnl_matrix
e9ba886b proper m_LetArrayManageMemory default during move-assign operator= for vnl_vector and vnl_matrix
08db1699 bvgl_k_nearest_neighbors_3d let compiler choose swap method
422ce727 bvgl_k_nearest_neighbors_3d: default member variable init, code cleanup
595d245c bvgl_register_ptsets_3d_rigid: default member variable init, code cleanup
44215864 bvgl_register_ptsets_3d_rigid: knn_fixed initialization
c46d4cd5 ENH: (CONTRIB) bpgl rectification parameter operator<<
f7b8a2f8 ENH: (CONTRIB) add 'rectify_z' parameter to rectify_affine_image_pair in bbas python adaptor
92035a81 update bpgl_heightmap_from_disparity with new class, simplifying overall interface and increasing code reuse
5e6f2ef9 update bpgl_heightmap_from_disparity templates
4dcf63f8 update bsgm_prob_pairwise_dsm for bpgl_heightmap_from_disparity compatibility
a706e542 update bpgl_heightmap_from_disparity_process for bpgl_heightmap compatibility (inputs should match floating point disparity image)
a0323a08 bpgl_heightmap_from_disparity - gridding parameter access in class
613f32f6 bpgl_heightmap individual templates
f5f59722 bpgl_3d_from_disparity Templates
122dbba7 bpgl_3d_from_disparity return type same as input type
9edbe1a8 update bpgl algo tests
05fbd3c0 bpgl_heightmap_from_disparity: pointset bounds check with small tolerance
b94fdb27 bvgl_k_nearest_neighbors_2d - refactor for max_dist parameter (nabo accepts an additional maximum distance to permit fast pruning of distant points)
4bc8faea bvgl_k_nearest_neighbors_2d - test update
58ad1c1c bpgl_3d_from_disparity - eliminate implicit cast of vnl_matrix
08dcd322 bpgl_gridding - compatibility with bvgl_k_nearest_neighbors_2d refactor
429168c5 bpgl_gridding refactor: - linear_interp with double internals - expected neighbor range (between min/max number of neighbors) - max neighbor distance as gridding input (not as member of interp. class) - improve linear_interp against new test cases
ea2e6544 bpgl_heightmap_from_disparity - update for refactored bpgl_gridding compatibility - RANGE for expected number of neighbors (not single value) - simplify accessor names - consistent private member variable naming (underscore after name) - more forgiving test (accurate to a cm, e.g. 0.01 tolerance)
a1f805b9 bsgm_prob_pairwise_dsm refactor - update for underlying bpgl_gridding & bpgl_heightmap (min/max neighbors, neighbor max_dist) - simplify accessor names - pairwise params with default values & comments
1f10da47 vpgl/algo fix failing test - use deterministic random number for repeatable tests
Hans Johnson (34):
422ed2fc STYLE: Change boilerplate code to generic
1d29e371 COMP: Fix compiler warning of missing header.
46f437c7 COMP: Remove outdated compiler flags.
607261ec COMP: Clang 9.0 ambiguous function mismatch failure
a210e3f6 COMP: Use lighter weight std::array<> with rigid size of 2
142d781e STYLE: Use override statements for C++11
43663ec5 COMP: C++17 deprecates bind2nd and bind1st functions
d3eca199 STYLE: Remove unused macros, and simplify macros
a46ec223 COMP: Match types change unsigned n to size_t
944cb63e ENH: Add noexcept to swap.
9529c45f COMP: Fix macro code style warning of extra ';'
b323f3dd COMP: Match function signatures with values tested
d3988d4b PERF: Use const references to avoid unnecessary copying
5eae006e COMP: Hide unused function when not testing memory leaks.
c123135b STYLE: TEST_MAIN macro is a block, and should not end with ';'
76305bb2 ENH: Add matched update command
102fe942 PERF: Simplify logic for mem data copy.
eeb7f7df STYLE: Use default member initialization
02f7a477 COMP: Provide C++11 variant of infinity comparisons
954e07c9 COMP: Move assignment operators should be marked noexcept
84ff1bba STYLE: Simplify code by removing manual RVO optimizations
262cefd6 STYLE: Remove manual return value optimization code
fd3386f1 STYLE: Remove unnecessary vnl_tag.h file
22eee046 ENH: Refactor to make ivars private
8af766d8 STYLE: Change private member name to private constructor
bbb9363b ENH: Explicitly disable operator=, add type conversion to non-ref
5c9e4a28 ENH: Make cast conversion & as_ref as_[matrix|vector|ref] consistent
dd7689cf PERF: Add move constructors and move assignment for vnl_vector
8b3c116e STYLE: Add small testing code for conversion testing.
09a6ec98 COMP: Avoid use of deprecated implicit conversions.
031dde96 COMP: Avoid use of deprecated implicit conversions in config
f002d6c1 ENH: Update version number to 2.1.2.2
ccdcf37b ENH: Add options to manage backward compatibility
249238aa BUG: The vnl_vector & vnl_matrix destructor should be virtual
Joseph Mundy (13):
8dd518bb added ptset ops
b6ef9ad0 classify roughness
af46d931 added comments to register ptsets
7925dc6e Added a spike removal class
8bdee65a Added accessor for invalid z value
1c4ee3dc allow two cluster model for nearest
42d036f4 replace missing functor clust_greater
8615a077 added intertile graph solver
7f793514 reduced verbose print out
9366ba00 invalid lsqr reference
0a1ec19b 2nd try at fixing levmarq reference
42017871 fixed metadata test
c240f72c update pair selection metadata to agree with terra
Niels Dekker (3):
aaf7a60f BUG: Fix issue InsightSoftwareConsortium#663, make vnl_bignum constructor for int types generic
9f4685c0 ENH: Fix issue InsightSoftwareConsortium#664: vnl_rational numerator, denominator both int64_t
33eb3de2 PERF: Add C++11 move-constructor and move-assignment to vnl_vector
Noah Johnson (10):
eff69c30 Added error checking to acal_f_utils::read_affine_cameras
78ab1990 Fixed bound checks in bpgl_rectify_affine_image_pair::compute_rectification
7188f07d Fixed a bug in SDET classify, where the valid image bounds could be negative, causing an invalid allocation
59117ebe Fixing VPGL geo camera bug, adding support for no-data values to vil tiffs, adding pointset registration to bvgl, adding a bsgm pair selector, and adding scalar image support to bpgl
3c262d92 Updating bvgl algo tests
4c265268 Added TIFF CMake message, to parallel the GeoTiff message. Useful for determining if VIL will be using your system's libtiff, or v3p
34ad4054 Allow rectification even if points in the zero disparity plane project outside of the scene bounding box. Add a check to ensure the overlap is above a certain percentage.
54313193 style changes
d99c05c6 style changes
20cdd55b Fixed a bug with extracting the scalar values during bpgl_heightmap_from_disparity::_heightmap_from_pointset. Missing i=0, but directly accessing the pointset's scalars vector is even easier.
Tim Cootes (2):
6eedbd55 Tweak in commented out code
84bd0b87 Removed v2i format, which causes problems.
clucock1 (1):
ba50514f Core tests requiring files (InsightSoftwareConsortium#669)
drewgilliam (1):
140a1250 Revert "PERF: Add C++11 move-constructor and move-assignment to vnl_vector"
Change-Id: I152912767ca8377c1850374eb30e9d816e188911
blowekamp
pushed a commit
to blowekamp/ITK
that referenced
this pull request
Nov 18, 2019
Run the UpdateFromUpstream.sh script to extract upstream VNL
using the following shell commands.
$ git archive --prefix=upstream-vnl/ 13735a37 --
CMakeLists.txt
config/cmake
core/CMakeLists.txt
core/testlib
core/vnl
core/vxl_config.h.in
core/vxl_copyright.h
core/vxl_version.h
v3p/CMakeLists.txt
v3p/netlib
vcl
| tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 7cc97a62..13735a37
Bradley Lowekamp (2):
69fbbe90 COMP: Address unused parameter in defaulted methods warning
13735a37 DOC: Recommend explicitly using vnl_matrix_inverse.as_matrix()
Chris Johnson (2):
16071b5c Fix failing build
c774959e Fix compiler error
Cynthia Lucock (7):
3ce6a5f1 corrected rounding and tested for NaN in bsgm
8f235198 deleted -0.5 from rounding and got rid of signbit
36c8d126 corrected use of isnan to std::isnan
f7b66275 brl fixed new unreferenced local variable warnings
2606874a fixed warnings signed/unsigned mismatch in brl
d0438a98 fixed warnings type cast pointer truncation in brl
5ab68c93 fixed type warnings in vgui_range_map
Daniel Crispell (2):
d80d07b8 BUG: regularize solution to improve stability of linear interpolation
42ff8459 COMP: fix various compiler errors in contrib (Apple clang version 11.0.0)
Drew Gilliam (38):
361f4d4c for travisci, add --output-on-failure flag to ctest to report full test failures
4ef3f129 move vnl_random to header file in bvgl_register_ptsets_3d_rigid
dc9dc29b disable (again) failing tests in betr
70cfa05c remove failing test (contrib/mul/vimt/tests/test_v2i)
405aab16 add initializer_list for vpgl_rational_order to permit easy iteration over enum values
52df64be increment version to 2.0.2.2
edd75431 vpgl_rational_order tests
2d30f5a0 travis update - switch to ninja, enable build caching
cec6ab29 disable travis cache
64ba44d2 travis CI update: - fix caching bug (accidental caching of source that overwrote new git checkout) - improve coverage with multiple gcc versions - full build on all pull requests & cron jobs
ded04ace missing stdexcept header in vul_string.cxx (issue for gcc 4.9.4)
4dfc42cb swap recently added 'm_LetArrayManageMemory' member variable for vnl_matrix and vnl_vector
3575dfd6 more swap tests for vnl_vector and vnl_matrix
e9ba886b proper m_LetArrayManageMemory default during move-assign operator= for vnl_vector and vnl_matrix
08db1699 bvgl_k_nearest_neighbors_3d let compiler choose swap method
422ce727 bvgl_k_nearest_neighbors_3d: default member variable init, code cleanup
595d245c bvgl_register_ptsets_3d_rigid: default member variable init, code cleanup
44215864 bvgl_register_ptsets_3d_rigid: knn_fixed initialization
c46d4cd5 ENH: (CONTRIB) bpgl rectification parameter operator<<
f7b8a2f8 ENH: (CONTRIB) add 'rectify_z' parameter to rectify_affine_image_pair in bbas python adaptor
92035a81 update bpgl_heightmap_from_disparity with new class, simplifying overall interface and increasing code reuse
5e6f2ef9 update bpgl_heightmap_from_disparity templates
4dcf63f8 update bsgm_prob_pairwise_dsm for bpgl_heightmap_from_disparity compatibility
a706e542 update bpgl_heightmap_from_disparity_process for bpgl_heightmap compatibility (inputs should match floating point disparity image)
a0323a08 bpgl_heightmap_from_disparity - gridding parameter access in class
613f32f6 bpgl_heightmap individual templates
f5f59722 bpgl_3d_from_disparity Templates
122dbba7 bpgl_3d_from_disparity return type same as input type
9edbe1a8 update bpgl algo tests
05fbd3c0 bpgl_heightmap_from_disparity: pointset bounds check with small tolerance
b94fdb27 bvgl_k_nearest_neighbors_2d - refactor for max_dist parameter (nabo accepts an additional maximum distance to permit fast pruning of distant points)
4bc8faea bvgl_k_nearest_neighbors_2d - test update
58ad1c1c bpgl_3d_from_disparity - eliminate implicit cast of vnl_matrix
08dcd322 bpgl_gridding - compatibility with bvgl_k_nearest_neighbors_2d refactor
429168c5 bpgl_gridding refactor: - linear_interp with double internals - expected neighbor range (between min/max number of neighbors) - max neighbor distance as gridding input (not as member of interp. class) - improve linear_interp against new test cases
ea2e6544 bpgl_heightmap_from_disparity - update for refactored bpgl_gridding compatibility - RANGE for expected number of neighbors (not single value) - simplify accessor names - consistent private member variable naming (underscore after name) - more forgiving test (accurate to a cm, e.g. 0.01 tolerance)
a1f805b9 bsgm_prob_pairwise_dsm refactor - update for underlying bpgl_gridding & bpgl_heightmap (min/max neighbors, neighbor max_dist) - simplify accessor names - pairwise params with default values & comments
1f10da47 vpgl/algo fix failing test - use deterministic random number for repeatable tests
Hans Johnson (34):
422ed2fc STYLE: Change boilerplate code to generic
1d29e371 COMP: Fix compiler warning of missing header.
46f437c7 COMP: Remove outdated compiler flags.
607261ec COMP: Clang 9.0 ambiguous function mismatch failure
a210e3f6 COMP: Use lighter weight std::array<> with rigid size of 2
142d781e STYLE: Use override statements for C++11
43663ec5 COMP: C++17 deprecates bind2nd and bind1st functions
d3eca199 STYLE: Remove unused macros, and simplify macros
a46ec223 COMP: Match types change unsigned n to size_t
944cb63e ENH: Add noexcept to swap.
9529c45f COMP: Fix macro code style warning of extra ';'
b323f3dd COMP: Match function signatures with values tested
d3988d4b PERF: Use const references to avoid unnecessary copying
5eae006e COMP: Hide unused function when not testing memory leaks.
c123135b STYLE: TEST_MAIN macro is a block, and should not end with ';'
76305bb2 ENH: Add matched update command
102fe942 PERF: Simplify logic for mem data copy.
eeb7f7df STYLE: Use default member initialization
02f7a477 COMP: Provide C++11 variant of infinity comparisons
954e07c9 COMP: Move assignment operators should be marked noexcept
84ff1bba STYLE: Simplify code by removing manual RVO optimizations
262cefd6 STYLE: Remove manual return value optimization code
fd3386f1 STYLE: Remove unnecessary vnl_tag.h file
22eee046 ENH: Refactor to make ivars private
8af766d8 STYLE: Change private member name to private constructor
bbb9363b ENH: Explicitly disable operator=, add type conversion to non-ref
5c9e4a28 ENH: Make cast conversion & as_ref as_[matrix|vector|ref] consistent
dd7689cf PERF: Add move constructors and move assignment for vnl_vector
8b3c116e STYLE: Add small testing code for conversion testing.
09a6ec98 COMP: Avoid use of deprecated implicit conversions.
031dde96 COMP: Avoid use of deprecated implicit conversions in config
f002d6c1 ENH: Update version number to 2.1.2.2
ccdcf37b ENH: Add options to manage backward compatibility
249238aa BUG: The vnl_vector & vnl_matrix destructor should be virtual
Joseph Mundy (13):
8dd518bb added ptset ops
b6ef9ad0 classify roughness
af46d931 added comments to register ptsets
7925dc6e Added a spike removal class
8bdee65a Added accessor for invalid z value
1c4ee3dc allow two cluster model for nearest
42d036f4 replace missing functor clust_greater
8615a077 added intertile graph solver
7f793514 reduced verbose print out
9366ba00 invalid lsqr reference
0a1ec19b 2nd try at fixing levmarq reference
42017871 fixed metadata test
c240f72c update pair selection metadata to agree with terra
Niels Dekker (3):
aaf7a60f BUG: Fix issue InsightSoftwareConsortium#663, make vnl_bignum constructor for int types generic
9f4685c0 ENH: Fix issue InsightSoftwareConsortium#664: vnl_rational numerator, denominator both int64_t
33eb3de2 PERF: Add C++11 move-constructor and move-assignment to vnl_vector
Noah Johnson (10):
eff69c30 Added error checking to acal_f_utils::read_affine_cameras
78ab1990 Fixed bound checks in bpgl_rectify_affine_image_pair::compute_rectification
7188f07d Fixed a bug in SDET classify, where the valid image bounds could be negative, causing an invalid allocation
59117ebe Fixing VPGL geo camera bug, adding support for no-data values to vil tiffs, adding pointset registration to bvgl, adding a bsgm pair selector, and adding scalar image support to bpgl
3c262d92 Updating bvgl algo tests
4c265268 Added TIFF CMake message, to parallel the GeoTiff message. Useful for determining if VIL will be using your system's libtiff, or v3p
34ad4054 Allow rectification even if points in the zero disparity plane project outside of the scene bounding box. Add a check to ensure the overlap is above a certain percentage.
54313193 style changes
d99c05c6 style changes
20cdd55b Fixed a bug with extracting the scalar values during bpgl_heightmap_from_disparity::_heightmap_from_pointset. Missing i=0, but directly accessing the pointset's scalars vector is even easier.
Tim Cootes (2):
6eedbd55 Tweak in commented out code
84bd0b87 Removed v2i format, which causes problems.
clucock1 (1):
ba50514f Core tests requiring files (InsightSoftwareConsortium#669)
drewgilliam (1):
140a1250 Revert "PERF: Add C++11 move-constructor and move-assignment to vnl_vector"
Change-Id: I29c6ef98a92eae50072cd94dab420cfa3afdee4c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename remote module maintenance script to better reflect its purpose.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.