Skip to content

BUG: Add missing ITKImageGrid circle.png content links#654

Merged
hjmjohnson merged 2 commits intoInsightSoftwareConsortium:masterfrom
thewtex:circle.png-content-links
Mar 30, 2019
Merged

BUG: Add missing ITKImageGrid circle.png content links#654
hjmjohnson merged 2 commits intoInsightSoftwareConsortium:masterfrom
thewtex:circle.png-content-links

Conversation

@thewtex
Copy link
Member

@thewtex thewtex commented Mar 29, 2019

No description provided.

@thewtex thewtex requested review from blowekamp and dzenanz March 29, 2019 17:40
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzenanz
Copy link
Member

dzenanz commented Mar 29, 2019

I guess @romangrothausmann was right:

WARNING: In /home/vsts/work/1/s/Modules/Core/TestKernel/include/itkPipelineMonitorImageFilter.hxx, line 72
PipelineMonitorImageFilter (0x2f9e150): Streamed pipeline was executed 8 times which was not the expected number 4 of times.

But also

Test failed.
Exception detected while reading /home/vsts/work/1/s-build/ExternalData/Modules/Filtering/ImageGrid/test/Baseline/ResampleImageTest2.mha :  Could not create IO object for reading file /home/vsts/work/1/s-build/Testing/Temporary/ResampleImageTest2a.mha
The file doesn't exist. 
Filename = /home/vsts/work/1/s-build/Testing/Temporary/ResampleImageTest2a.mha
<DartMeasurement name="BaselineImageName" type="text/string">INVALID_BASELINE_GIVEN</DartMeasurement>

Fix expected number of streaming updates.

Fix output file names to correspond with comparison and not clobber
itkResampleImageTest2 output file names.

Disable baseline until consistency is improved per Issue InsightSoftwareConsortium#655.
@hjmjohnson hjmjohnson merged commit cb13129 into InsightSoftwareConsortium:master Mar 30, 2019
@thewtex thewtex deleted the circle.png-content-links branch March 30, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants