COMP: Specify type in LiThresholdCalculator min call#597
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 18, 2019
Merged
COMP: Specify type in LiThresholdCalculator min call#597dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
To address:
In file included from /home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.h:87:0,
from Wrapping/Typedefs/itkLiThresholdCalculatorSwigInterface.h:19,
from Wrapping/Modules/ITKThresholding/itkLiThresholdCalculatorPython.cpp:3371:
/home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.hxx: In instantiation of ‘void itk::LiThresholdCalculator<THistogram, TOutput>::GenerateData() [with THistogram = itk::Statistics::Histogram<float>; TOutput = float]’:
Wrapping/Modules/ITKThresholding/itkLiThresholdCalculatorPython.cpp:8112:1: required from here
/home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.hxx:65:34: error: no matching function for call to ‘min(const MeasurementType&, double)’
const double bin_min = std::min(histogram->GetBinMin(0,0), 0.0);
thewtex
requested review from
blowekamp,
dzenanz,
fbudin69500,
hjmjohnson and
phcerdan
dzenanz
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to:
#135
To address:
In file included from /home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.h:87:0,
from Wrapping/Typedefs/itkLiThresholdCalculatorSwigInterface.h:19,
from Wrapping/Modules/ITKThresholding/itkLiThresholdCalculatorPython.cpp:3371:
/home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.hxx: In instantiation of ‘void itk::LiThresholdCalculator<THistogram, TOutput>::GenerateData() [with THistogram = itk::Statistics::Histogram; TOutput = float]’:
Wrapping/Modules/ITKThresholding/itkLiThresholdCalculatorPython.cpp:8112:1: required from here
/home/kitware/mattm/ITK/Modules/Filtering/Thresholding/include/itkLiThresholdCalculator.hxx:65:34: error: no matching function for call to ‘min(const MeasurementType&, double)’
const double bin_min = std::min(histogram->GetBinMin(0,0), 0.0);