STYLE: Don't call static TypeAsString functions via instances (Examples)#5431
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Jun 21, 2025
Conversation
Replaced function calls of the form `instance->MemberFunction(x)` with `itk::T::MemberFunction(x)`, for the static member functions `GetPixelTypeAsString` and `GetComponentTypeAsString`, in Examples. Follow-up to pull request InsightSoftwareConsortium#5391 commit 45e93bb
github-actions
bot
added
area:Examples
hjmjohnson
approved these changes
Jun 21, 2025
hjmjohnson
merged commit 42ff572
into
InsightSoftwareConsortium:master
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced function calls of the form
instance->MemberFunction(x)withitk::T::MemberFunction(x), for the static member functionsGetPixelTypeAsStringandGetComponentTypeAsString, in Examples.Follow-up to pull request #5391 commit 45e93bb