Skip to content

ENH: Add printing of FileNames to ImageSeriesReader#5356

Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:series_reader_print_filenames
May 21, 2025
Merged

ENH: Add printing of FileNames to ImageSeriesReader#5356
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:series_reader_print_filenames

Conversation

@blowekamp
Copy link
Member

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation area:IO Issues affecting the IO module labels May 20, 2025
@dzenanz
Copy link
Member

dzenanz commented May 20, 2025

/azp run ITK.Linux.Python

@blowekamp blowekamp force-pushed the series_reader_print_filenames branch from 28eb037 to e3e2e45 Compare May 20, 2025 20:40
Copy link
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blowekamp 👍

@blowekamp blowekamp marked this pull request as ready for review May 21, 2025 14:09
@blowekamp
Copy link
Member Author

Is there some configuration issue with the ITK.Linux and ITK.Linux.Python build?

@dzenanz
Copy link
Member

dzenanz commented May 21, 2025

@thewtex might know.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex
Copy link
Member

thewtex commented May 21, 2025

image

@thewtex
Copy link
Member

thewtex commented May 21, 2025

Azure Pipelines dropped support for the image. Addressed in #5359

@blowekamp blowekamp merged commit 829c841 into InsightSoftwareConsortium:master May 21, 2025
14 of 16 checks passed
blowekamp pushed a commit to blowekamp/ITK that referenced this pull request Feb 13, 2026
This is change is pulled from commit
b09008ea0379e7b113ffdde4402860ba467ace13 upstream.

Define __STDC_WANT_IEC_60559_TYPES_EXT__ before including other headers (InsightSoftwareConsortium#5356)
Some standard headers might implicitly include `float.h`. If that happens
before `__STDC_WANT_IEC_60559_TYPES_EXT__` is defined, the macros that
are needed for the `_Float16` data type (like `FLT16_MAX`) might not be
defined.

That is happening with mingw-w64 headers since the following change: mingw-w64/mingw-w64@b40b6a0

Define `__STDC_WANT_IEC_60559_TYPES_EXT__` before including other headers
in `H5private.h` to make that scenario less likely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:IO Issues affecting the IO module type:Enhancement Improvement of existing methods or implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants