Skip to content

STYLE: Replace rand() calls with std::mt19937 in ImageAdaptor test #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewtex merged 1 commit into from
May 14, 2025
Merged

STYLE: Replace rand() calls with std::mt19937 in ImageAdaptor test #5348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Modules/Core/ImageAdaptors/test/itkComplexConjugateImageAdaptorTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "itkComplexConjugateImageAdaptor.h"
#include "itkImageRegionIterator.h"
#include <random>


using PixelType = std::complex<float>;
Expand All @@ -34,13 +35,13 @@ itkComplexConjugateImageAdaptorTest(int, char *[])
image->Allocate();
const ImageType::RegionType region = image->GetLargestPossibleRegion();

srand(50L);
std::mt19937 randomNumberEngine;
std::uniform_real_distribution<float> randomNumberDistribution;

itk::ImageRegionIterator<ImageType> iter(image, region);
for (iter.GoToBegin(); !iter.IsAtEnd(); ++iter)
{
auto randMax = static_cast<float>(RAND_MAX);
const PixelType pixel(static_cast<float>(rand()) / randMax, static_cast<float>(rand()) / randMax);
const PixelType pixel(randomNumberDistribution(randomNumberEngine), randomNumberDistribution(randomNumberEngine));
Comment on lines -42 to +44
Copy link
Contributor Author

@N-Dekker N-Dekker May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this pull request was inspired by a discussion we had before about the use of static_cast<float>(RAND_MAX), at #5337 (comment) It appeared that RAND_MAX is platform dependent, so this static_cast<float> may or may not be lossless. Which made me want to get rid of static_cast<float>(RAND_MAX) 👹 !

iter.Set(pixel);
}

Expand Down
Loading