Skip to content

ENH: Update external libminc to write backward-compatible HDF5 1.8.x files#53

Closed
gdevenyi wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
gdevenyi:update-minc
Closed

ENH: Update external libminc to write backward-compatible HDF5 1.8.x files#53
gdevenyi wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
gdevenyi:update-minc

Conversation

@gdevenyi
Copy link
Contributor

@gdevenyi gdevenyi commented Aug 9, 2018

Pull in updated libminc to fix writing HDF5 on-disk format which isn't backwards compatible.

vfonov and others added 2 commits August 9, 2018 14:01
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ ce4333ca -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
 | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' f2d06a67..ce4333ca

Bradley Lowekamp (1):
      ce789353 COMP:  Enable CMP0063 NEW, support setting visibility properties

Gabriel A. Devenyi (3):
      8844cf48 Limit HDF5 file versioning to 1.8.x
      c9a9c843 Move the location of version setting for HDF5
      6d6614b4 Switch to checking defines instead of an enum

Vladimir S. FONOV (5):
      e2a099f6 minor change
      6b471c8a HACK to fix voxel-loop operation for discrete data type on MINC1 file
      a9cbe135 Reversed the hack for MINC1
      719b3fb4 Updated README to have better explanation of MINC_FILE_CACHE_MB
      e75a936c Updated patch number

Change-Id: I0d38a685a44796e0df43b42f880022cc19c4fce9
@itkrobot
Copy link
Collaborator

itkrobot commented Aug 9, 2018

Can one of the admins verify this patch?

1 similar comment
@itkrobot
Copy link
Collaborator

itkrobot commented Aug 9, 2018

Can one of the admins verify this patch?

@dzenanz
Copy link
Member

dzenanz commented Aug 9, 2018

We haven't switched the contribution process to GitHub for main ITK repository yet. Can you submit your patch to gerrit?

@gdevenyi
Copy link
Contributor Author

gdevenyi commented Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants