Skip to content

STYLE: Move empty member functions from .hxx to .h#5206

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Move-empty-member-functions-from-hxx-to-h
Feb 4, 2025
Merged

STYLE: Move empty member functions from .hxx to .h#5206
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Move-empty-member-functions-from-hxx-to-h

Conversation

@N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Feb 3, 2025

Moved the member function definitions of member functions that have an empty member function definition from their "itk*.hxx" file to the corresponding "itk*.h" file, and into their class definition.

Found by regular expression ^..[^:,].+\)\r\n{} in "itk*.hxx" files.

@dpshamonin Denis, please have a look!

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Feb 3, 2025
@dpshamonin
Copy link
Contributor

Great!

@N-Dekker N-Dekker force-pushed the Move-empty-member-functions-from-hxx-to-h branch from 7e3b1bd to b936bd4 Compare February 3, 2025 13:06
Moved the member function definitions of member functions that have an empty
member function definition from their "itk*.hxx" file to the corresponding
"itk*.h" file, and into their class definition.

Found by regular expression `^..[^:,].+\)\r\n{}` in "itk*.hxx" files.

- Follow-up to pull request InsightSoftwareConsortium#5198
commit b94770d
"STYLE: Move empty member functions with empty param list from .hxx to .h"
@N-Dekker N-Dekker force-pushed the Move-empty-member-functions-from-hxx-to-h branch from b936bd4 to 023e5a7 Compare February 3, 2025 14:46
@N-Dekker N-Dekker marked this pull request as ready for review February 3, 2025 15:06
@dzenanz dzenanz merged commit 8ae9f91 into InsightSoftwareConsortium:master Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Numerics Issues affecting the Numerics module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants