STYLE: Miscellaneous ImageCompose test style enhancements#5205
Merged
jhlegarreta merged 6 commits intoInsightSoftwareConsortium:masterfrom Feb 2, 2025
Merged
Conversation
Use `ITK_TRY_EXPECT_NO_EXCEPTION` macro in `ImageCompose` tests: - Use `ITK_TRY_EXPECT_NO_EXCEPTION` macro when updating filters in lieu of `try/catch` blocks for the sake of readability and compactness, and to save typing/avoid boilerplate code. - Only place with the macro the code that might raise exceptions.
Conform to ITK style guidelines in test ending message across the `ImageCompose` module test files: add it where missing and use the same message consistently. Take advantage of the commit to remove unnecessary comments about objects being destroyed when exiting the test main method.
Conform to ITK style guidelines in test argument check message across the `ImageCompose` module test files: add the missing argument message where missing and use the same message consistently.
Perform first the test input argument check across the `ImageCompose` module test files. Take advantage of the commit to add the missing argument message where missing and use the same message consistently.
Remove unnecessary/uninformative comment block in `ImageCompose` module test.
Do not capitalize variable first letter: adhere to ITK style guidelines.
github-actions
bot
added
type:Testing
jhlegarreta
force-pushed
the
MiscImageComposeTestStyleEnh
branch
from
9a82d83 to
5042dc9
Compare
dzenanz
approved these changes
Feb 2, 2025
jhlegarreta
merged commit ed1eaec
into
InsightSoftwareConsortium:master
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITK_TRY_EXPECT_NO_EXCEPTIONmacro inImageComposetestsPR Checklist