Two compile fixes needed for my project#5
Closed
eile wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Closed
Two compile fixes needed for my project#5eile wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
eile wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
added 2 commits
July 30, 2014 13:48
Change-Id: Iff644ab35fa71a9d0dda0feb0619267092d08290
Change-Id: Iafe453cf935cca34b0c7a8d8b14e35af1b22bbf5
Member
|
Hello, Thank you for taking the time to fix this issue and push it upstream! We use the gerrit system for review and merging patch. It would be appreciated if you push the topic to gerrit for review: |
Author
|
I did do so two days ago for the first one: http://review.source.kitware.com/#/c/16399/ Since the reviews seem to take some time, we'll need a github fork anyways to keep our code base compiling, so I figured I can as well use the easier PR workflow. |
Member
|
Thank you very much for contributing this upstream. This patch need to actually first go into the KWSys project then into ITK. |
kwrobot
referenced
this pull request
in Kitware/ITK
Dec 16, 2016
…tion
Alexander Schmidt-Richberg (1):
BUG: Small bugs fixed to avoid compiler warnings (unsigned int and unused variable).
Francois Budin (6):
ENH: Replacing test data with MD5
STYLE: Improve style to pass KWStyle test
DOC: Missing backslash in documentation
COMP: Remove compilation warnings from Visual Studio
COMP: Correct warning due to locally defined symbol
Merge pull request InsightSoftwareConsortium#9 from fbudin69500/locally_defined_symbol
aschmiri (5):
Merge pull request #3 from thewtex/doxygen-warnings
Merge pull request #4 from fbudin69500/DOC_missing_backslash_in_documentation
Merge pull request #5 from fbudin69500/ENH_replace_test_data_with_MD5
Merge pull request #6 from fbudin69500/ImproveStyle
Merge pull request InsightSoftwareConsortium#7 from fbudin69500/remove_VS_warning_cherry_picked
Change-Id: Ibb959bc84e01edb6c3b78e0984d9f029992ff5af
2 tasks
fbordignon
added a commit
to fbordignon/ITK
that referenced
this pull request
Jan 20, 2023
Hello, I was having trouble with an external python calling the itk function as shared below. The ?? sometimes indicates a callback but to be sure I searched all instances of H5VL_group_close and only H5G__close_cb was calling it and it is currently unmangled. I will test this soon and report back. <details> ``` #0 0x00007febfdaa8b49 in itk_H5CX_get_vol_wrap_ctx () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1 InsightSoftwareConsortium#1 0x00007febfdd23a44 in itk_H5VL_set_vol_wrapper () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1 InsightSoftwareConsortium#2 0x00007febfdd1870b in itk_H5VL_group_close () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1 InsightSoftwareConsortium#3 0x00007febfdb4b11d in ?? () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1 InsightSoftwareConsortium#4 0x00007fead7b7d480 in H5I_dec_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0 InsightSoftwareConsortium#5 0x00007fead7b7d544 in H5I_dec_app_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0 InsightSoftwareConsortium#6 0x00007fead7b79fd1 in H5Idec_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0 ``` </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.