STYLE: Variable set but not used suppression #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
added
type:Compiler
github-actions
bot
added
area:Numerics
N-Dekker
reviewed
Nov 21, 2024
Comment on lines
579
to
581
| double chebycoefs0 = 0.0; // the constant term | ||
| double datatotal = 0.0; | ||
| double a0norm = 1.0; | ||
| // NOT USED double chebycoefs0 = 0.0; // the constant term | ||
| // NOT USED double datatotal = 0.0; | ||
| // NOT USED double a0norm = 1.0; |
There was a problem hiding this comment.
If those variables are really useless, please consider simply removing those lines of code, instead of just commenting them out. 🙏
There was a problem hiding this comment.
I agree. Restoring the variables is easy with versioned history, if it is ever needed.
There was a problem hiding this comment.
Removing the comment-out code might actually please the spell checker at the CI, which specifically checks comments! It now complains, saying:
itkFEMImageMetricLoad.hxx line: 580 word: datatotal
ITK/Modules/Numerics/FEM/include/itkFEMImageMetricLoad.hxx:579:10: warning: variable 'chebycoefs0' set but not used [-Wunused-but-set-variable]
hjmjohnson
force-pushed
the
remove-unused-variables
branch
from
4e89b42 to
3e73585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITK/Modules/Numerics/FEM/include/itkFEMImageMetricLoad.hxx:579:10: warning: variable 'chebycoefs0' set but not used [-Wunused-but-set-variable]
PR Checklist