Skip to content

COMP: macOS-11 Azure CI environment EOL#4726

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:azure-macos11-eol
Jun 20, 2024
Merged

COMP: macOS-11 Azure CI environment EOL#4726
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:azure-macos11-eol

Conversation

@hjmjohnson
Copy link
Member

@hjmjohnson hjmjohnson commented Jun 17, 2024

The macOS-11 environment is deprecated and scheduled to be removed on June 28th, 2024.

https://learn.microsoft.com/en-us/azure/devops/release-notes/features-timeline-released

PR Checklist

@hjmjohnson hjmjohnson added the type:Compiler Compiler support or related warnings label Jun 17, 2024
@hjmjohnson hjmjohnson requested a review from thewtex June 17, 2024 17:56
@hjmjohnson hjmjohnson self-assigned this Jun 17, 2024
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jun 17, 2024
dzenanz
dzenanz approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Matt should review too.

@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 18, 2024

@thewtex Would you mind looking this over please?

thewtex
thewtex requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump to macos-12 (also Intel) because macos-14 is ARM and we are already testing it with GitHub Actions.

@thewtex
Copy link
Member

thewtex commented Jun 18, 2024

Azure Pipelines uses the same images as GitHub Actions:

https://github.com/actions/runner-images

@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 19, 2024

Changes made.

@hjmjohnson hjmjohnson requested a review from thewtex June 19, 2024 01:08
thewtex
thewtex approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjmjohnson thanks!

@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 19, 2024

/azp ITK.macOS.Python

@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 19, 2024

\azp ITK.macOS.Python

@thewtex
Copy link
Member

thewtex commented Jun 19, 2024

https://open.cdash.org/viewTest.php?onlyfailed&buildid=9697916

-> One failing, unstable test, itkLBFGS2Optimizerv4Test. Perhaps it is worth trying macos-13 for a compiler update while retaining Intel coverage.

@hjmjohnson hjmjohnson mentioned this pull request Jun 19, 2024
Merged
2 tasks
thewtex
thewtex approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hans

@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 19, 2024

@thewtex

FYI: https://github.com/actions/runner-images?tab=readme-ov-file

macOS-14-large is intel
macOS-14 is arm

If intel is what we are after, perhaps we just need to use the correct yaml label.

@thewtex
Copy link
Member

thewtex commented Jun 19, 2024

@hjmjohnson Last time I tried, macOS-14-large was not available for free / open source accounts.

@hjmjohnson
COMP: macOS-11 Azure CI environment EOL
e1b18c6 
The macOS-11 environment is deprecated and scheduled
to be removed on June 28th, 2024.

Update to macos-12 (also Intel) because macos-14 images
are ARM and the ARM testing is done with GitHub Actions.
@blowekamp
Copy link
Member

blowekamp commented Jun 20, 2024

Please consider also update the release-5.4 branch with this change to keep the release branch CI green.

@hjmjohnson hjmjohnson merged commit 87bcabf into InsightSoftwareConsortium:master Jun 20, 2024
@hjmjohnson hjmjohnson deleted the azure-macos11-eol branch June 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels

type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hjmjohnson @thewtex @blowekamp @dzenanz