Skip to content

ENH: Finalize ITKv5 const function API change#4704

Merged
N-Dekker merged 2 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson:initial-legacy-removals
Jun 13, 2024
Merged

ENH: Finalize ITKv5 const function API change#4704
N-Dekker merged 2 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson:initial-legacy-removals

Conversation

@hjmjohnson
Copy link
Member

@hjmjohnson hjmjohnson commented Jun 1, 2024 •
edited
Loading

The non-const API variants are no longer supported at compile-time.

Replace 'ITKv5_CONST' with 'const'.

PR Checklist

@hjmjohnson hjmjohnson added the type:Style Style changes: no logic impact (indentation, comments, naming) label Jun 1, 2024
@hjmjohnson hjmjohnson self-assigned this Jun 1, 2024
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module area:Remotes Issues affecting the Remote module area:Documentation Issues affecting the Documentation module and removed type:Style Style changes: no logic impact (indentation, comments, naming) labels Jun 1, 2024
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch from 43af41d to d0d6cab Compare June 1, 2024 00:33
@github-actions github-actions bot removed the area:Video Issues affecting the Video module label Jun 1, 2024
@dzenanz dzenanz requested a review from N-Dekker June 1, 2024 00:59
@hjmjohnson hjmjohnson marked this pull request as draft June 1, 2024 14:03
@hjmjohnson
Copy link
Member Author

hjmjohnson commented Jun 1, 2024 •
edited
Loading

This set of changes more rigorously enforces uses of C++11 and C++17 required standards rather than the aliases needed for older compilers.

@hjmjohnson hjmjohnson closed this Jun 1, 2024
@hjmjohnson hjmjohnson reopened this Jun 1, 2024
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch 3 times, most recently from df318fb to 0d102bb Compare June 4, 2024 16:02
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch 2 times, most recently from 7db7037 to db4c3c2 Compare June 10, 2024 01:37
N-Dekker
N-Dekker reviewed Jun 10, 2024
View reviewed changes
N-Dekker
N-Dekker reviewed Jun 10, 2024
View reviewed changes
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch from db4c3c2 to a10a1c5 Compare June 10, 2024 15:04
@hjmjohnson
ENH: Finalize ITKv5 const function API change
289550e 
The non-const API variants are no longer supported
at compiletime.

Replace 'ITKv5_CONST' with 'const'.
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch from a10a1c5 to 0843ade Compare June 12, 2024 17:11
@hjmjohnson hjmjohnson changed the title Initial legacy removals ENH: Finalize ITKv5 const function API change Jun 12, 2024
@hjmjohnson hjmjohnson marked this pull request as ready for review June 12, 2024 17:14
@hjmjohnson hjmjohnson force-pushed the initial-legacy-removals branch from 0843ade to 6523b28 Compare June 12, 2024 17:15
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation and removed type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Remotes Issues affecting the Remote module labels Jun 12, 2024
@hjmjohnson hjmjohnson requested a review from N-Dekker June 12, 2024 17:28
N-Dekker
N-Dekker reviewed Jun 12, 2024
View reviewed changes
Modules/Core/Common/include/itkMacro.h
# define ITKv5_CONST static_assert(false, "ERROR: ITKv5_CONST must be replaced with 'const'")
#else
// A macro for methods which are const in ITKv5, but not in ITKv4
// A macro for methods which are const in after ITKv4
Copy link
Contributor

@N-Dekker N-Dekker Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo: "in after" 😺 No problem to me, though 👍

N-Dekker
N-Dekker approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hans 👍

thewtex
thewtex approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@N-Dekker N-Dekker merged commit efe3dce into InsightSoftwareConsortium:master Jun 13, 2024
@hjmjohnson hjmjohnson deleted the initial-legacy-removals branch January 26, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@N-Dekker N-Dekker N-Dekker approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels

area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hjmjohnson @thewtex @dzenanz @N-Dekker