BUG: corrected logic for checking that streaming was not used#468
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Feb 5, 2019
Merged
Conversation
This was referenced Feb 5, 2019
dzenanz
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the logic for checking if streaming did not succeed with the final commits of #392, see comments there (#392 (comment)).
resample->SetInput( monitor->GetOutput() );was called twice (e9f951d#diff-50f53fc01f72ba938548d64a1218589bL122 and e9f951d#diff-50f53fc01f72ba938548d64a1218589bL137), so removed one to avoid problems in future modifications.Some minor changes are included as well.