Merged
Conversation
Code extracted from:
https://bitbucket.hdfgroup.org/scm/hdffv/hdf5.git
at commit 545c5fb2a957c245f283c6db5c429b7b89cda622 (hdf5_1_10_4).
Change-Id: Iae77b108bd1f83be1eaccf8e76540d4ad337e7a5
* upstream-HDF5: HDF5 2018-10-15 (545c5fb2)
Closed
dzenanz
approved these changes
Jan 10, 2019
dzenanz
requested changes
Jan 10, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I clicked "approve" before I saw the last commit. I think that minor version .4 does not introduce any new public symbols.
hjmjohnson
reviewed
Jan 16, 2019
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
It will be nice to have the updated HDF5 changes included.
thewtex
force-pushed
the
hdf5-update
branch
2 times, most recently
from
067c863 to
a721518
Compare
thewtex
force-pushed
the
hdf5-update
branch
2 times, most recently
from
3f6e9bc to
e9ffa15
Compare
Also fix the symbol identifier on Windows.
thewtex
force-pushed
the
hdf5-update
branch
2 times, most recently
from
5a1eb0b to
a0a885f
Compare
Member
Author
|
Verified locally on Emscripten and ready to go :-). |
Closed
hjmjohnson
added
the
type:Infrastructure
hjmjohnson
approved these changes
Feb 10, 2019
|
|
||
| if(NOT DEFINED INSTALLDIR) | ||
| set(INSTALLDIR "@CMAKE_INSTALL_PREFIX@") | ||
| set(INSTALLDIR "C:/Program Files/HDF_Group/@HDF5_PACKAGE_NAME@/@HDF5_PACKAGE_VERSION@") |
Member
There was a problem hiding this comment.
I don't think this affect ITK, and I think this is a bug in upstream.
Hard coded absolute paths are bad.
dzenanz
approved these changes
Feb 11, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos:
_prefixed mangled symbols