ENH: update C+11 headers and try compile for headers#38
Closed
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
ENH: update C+11 headers and try compile for headers#38blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
The try compiles for "stddef.h" and "sys/types.h" are not used in ITK so they were removed. The try compile for stdint.h has been removed for the expected C+11 standard cstdint. fenv.h remains used in itkFloatingPointExceptions.cxx because the usage is low level and system specific as opposed to complying with a standard usage. Change-Id: I9e176ae02de2eb9c7ec59bcb66ed884f16c61dab
Member
Author
|
@hjmjohnson Do you want to cherry pick this to the v5 C++11 topic? |
Member
|
Brad I was going rebase tonight. It’s my anniversary and I’m skiing at park city Utah with my wife today.
I’m sure there will be at least two merge conflicts to fix.
Hans
…Sent from my iPhone
On Jan 11, 2018, at 8:50 AM, Bradley Lowekamp ***@***.***> wrote:
@hjmjohnson Do you want to cherry pick this to the v5 C++11 topic?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
Cherry-picked. Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The try compiles for "stddef.h" and "sys/types.h" are not used in ITK
so they were removed.
The try compile for stdint.h has been removed for the expected C+11
standard cstdint.
fenv.h remains used in itkFloatingPointExceptions.cxx because the
usage is low level and system specific as opposed to complying with a
standard usage.
Change-Id: I9e176ae02de2eb9c7ec59bcb66ed884f16c61dab