WIP: ITKv5 initial conversion 20171210#37
Closed
hjmjohnson wants to merge 7 commits intoInsightSoftwareConsortium:masterfrom
Closed
WIP: ITKv5 initial conversion 20171210#37hjmjohnson wants to merge 7 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson wants to merge 7 commits intoInsightSoftwareConsortium:masterfrom
Conversation
hjmjohnson
force-pushed
the
ITKv5_InitialConversion_20171210
branch
6 times, most recently
from
9ce96d2 to
a6a467f
Compare
hjmjohnson
force-pushed
the
ITKv5_InitialConversion_20171210
branch
7 times, most recently
from
7c6bfe0 to
0e8e2c7
Compare
Change-Id: I17b5d0f7c64e82ec241e83f9e3a89c36ed3aae08
git grep -l "ITK_DELETED_FUNCTION" | fgrep -v itk_compiler_detection.h | fgrep -v itkMacro.h | fgrep -v CMakeLists.txt |fgrep -v .cmake | xargs sed -i '' -e "s/ITK_DELETED_FUNCTION/= delete/g" Change-Id: Idc84bf128df49db65cd5969457d7f58fefc560f1
git grep -l \"ITK_CONSTEXPR_VAR\" | fgrep -v itk_compiler_detection.h | fgrep -v itkMacro.h | fgrep -v CMakeLists.txt |fgrep -v .cmake | xargs sed -i '' -e \"s/ ITK_CONSTEXPR_VAR/ constexpr/g\" Change-Id: I618ad84d057dfaf4933f575e44ae60118997b2e5
In C++11 ITK_COMPILER_CXX_CONSTEXPR is always true for all cases, so remove conditional code. Change-Id: I72feb725070cdc246bac706e67d13a39270ef7cf
Change-Id: Icc3ccaa9d4f7cb61a01a8d7c17346ae46bd6e952
Features removed or deprecated: std::auto_ptr is deprecated, having been superseded by std::unique_ptr. https://stackoverflow.com/questions/3451099/stdauto-ptr-to-stdunique-ptr Function object base classes (std::unary_function, std::binary_function), adapters to pointers to functions and adapters to pointers to members, and binder classes are all deprecated. Both std::unary_function and std::binary_function are deprecated since C++11 and removed without any replacement from C++17. whole purpose of this commit is C++17 forward compatibility, which is important for projects written in C++17 that use ITK and need to pass according compiler flags for binary compatibility. See also https://stackoverflow.com/questions/33114656/replacement-for-binary-function. Change-Id: Ia7e1db579e8ac46935636ebfa5b73665dbf131a1
These scripts were found to be useful when migrating several packages to C++11 and modern cmake conventions during the ITKv5 transition. Change-Id: Id44c61189039d1c72e07672f3320f578c5284f18
hjmjohnson
force-pushed
the
ITKv5_InitialConversion_20171210
branch
from
0e8e2c7 to
85ebfd9
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Work In Progress not ready for merge
Merge request to test the CI system and to allow review of the patches.