BUG: Add itk::GaussianOperator debug methods#3432
Merged
tbirdso merged 2 commits intoInsightSoftwareConsortium:masterfrom May 17, 2022
Merged
BUG: Add itk::GaussianOperator debug methods#3432tbirdso merged 2 commits intoInsightSoftwareConsortium:masterfrom
itk::GaussianOperator debug methods#3432tbirdso merged 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
Hotfix for failing Linux/macOS builds where itkDebugMacro is not supported in `itk::GaussianOperator`.
github-actions
bot
added
area:Core
Contributor
Author
|
@Leengit if you have time would you please try building this branch? CI checks passed in #3423 which originally introduced the error, so it seems like a different build system is needed to verify. I am working on verifying whether |
Contributor
|
@tbirdso I am building and will let you know. |
Leengit
reviewed
May 17, 2022
Contributor
tbirdso
force-pushed
the
add-gaussian-operator-debug
branch
from
4f4da40 to
6fae53b
Compare
Contributor
Author
|
@Leengit Great to hear! I am not able to reproduce the original error on my local Linux setup, so we will have to go with your system's ability to reproduce. |
Leengit
reviewed
May 17, 2022
Addresses InsightSoftwareConsortium#3430 where `itkDebugMacro` fails in `itk::GaussianOperator` because it does not inherit from `itk::Object` and therefore does not implicitly define `GetDebug`.
tbirdso
force-pushed
the
add-gaussian-operator-debug
branch
from
6fae53b to
5c44b7f
Compare
thewtex
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3430 by mimicking
itk::Objectdebug interface methods so thatitkDebugMacroimplements valid debug code initk::GaussianOperator.itk::GaussianOperatorinherits from the baseitk::Neighborhoodwhich is a lightweight object not inheriting fromitk::Objectoritk::LightObject.itk::GaussianOperatoris more complex than other neighborhoods in that it takes in several user parameters and dynamically generates a discrete ND kernel function. In order to preserve the lightweight design of otheritk::Neighborhoodderivative classes while providing insight into the more complex inner workings ofitk::GaussianOperator, it is reasonable to re-implement theitk::Objectdebug interface at theitk::GaussianOperatorlevel.Depends on #3431 hotfix.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.