FastEvaluate(u) for both BSplineKernelFunction _and_ BSplineDerivativeKernelFunction #2731
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom Sep 14, 2021
Conversation
Follow-up to pull request InsightSoftwareConsortium#2716 commit 99f04d7 "ENH: Add static member function `BSplineKernelFunction::FastEvaluate(u)`"
github-actions
bot
added
area:Core
N-Dekker
force-pushed
the
BSplineDerivativeKernelFunction-FastEvaluate
branch
from
56b6036 to
311ac07
Compare
dzenanz
reviewed
Sep 13, 2021
Modules/Registration/Common/include/itkMattesMutualInformationImageToImageMetric.h
Show resolved
Hide resolved
Modules/Registration/Metricsv4/include/itkMattesMutualInformationImageToImageMetricv4.h
Show resolved
Hide resolved
Removed the two dynamically allocated "cubic BSpline kernel" data members from both `MattesMutualInformationImageToImageMetric` and `MattesMutualInformationImageToImageMetricv4`. Replaced the virtual `Evaluate` function calls by faster static member function calls, to the newly added `FastEvaluate` member functions of the corresponding `KernelFunction` classes. Follow-up to pull request InsightSoftwareConsortium#2716 commit c23944b "PERF: Remove BSplineInterpolationWeightFunction Kernel, use FastEvaluate"
N-Dekker
force-pushed
the
BSplineDerivativeKernelFunction-FastEvaluate
branch
from
311ac07 to
5947468
Compare
dzenanz
approved these changes
Sep 14, 2021
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jan 26, 2022
Paving the way for the introduction of `FastEvaluate` member functions, as introduced with ITK v5.3rc02: - ITK pull request InsightSoftwareConsortium/ITK#2716 commit InsightSoftwareConsortium/ITK@99f04d7 "ENH: Add static member function `BSplineKernelFunction::FastEvaluate(u)`" - ITK pull request InsightSoftwareConsortium/ITK#2731 commit InsightSoftwareConsortium/ITK@760ae12 "ENH: Add static `FastEvaluate(u)` to `BSplineDerivativeKernelFunction`"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jan 26, 2022
Similar to the `FastEvaluate` member functions, introduced with ITK v5.3rc02: - ITK pull request InsightSoftwareConsortium/ITK#2716 commit InsightSoftwareConsortium/ITK@99f04d7 "ENH: Add static member function `BSplineKernelFunction::FastEvaluate(u)`" - ITK pull request InsightSoftwareConsortium/ITK#2731 commit InsightSoftwareConsortium/ITK@760ae12 "ENH: Add static `FastEvaluate(u)` to `BSplineDerivativeKernelFunction`"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jan 27, 2022
Paving the way for the introduction of `FastEvaluate` member functions, as introduced with ITK v5.3rc02: - ITK pull request InsightSoftwareConsortium/ITK#2716 commit InsightSoftwareConsortium/ITK@99f04d7 "ENH: Add static member function `BSplineKernelFunction::FastEvaluate(u)`" - ITK pull request InsightSoftwareConsortium/ITK#2731 commit InsightSoftwareConsortium/ITK@760ae12 "ENH: Add static `FastEvaluate(u)` to `BSplineDerivativeKernelFunction`"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jan 27, 2022
Similar to the `FastEvaluate` member functions, introduced with ITK v5.3rc02: - ITK pull request InsightSoftwareConsortium/ITK#2716 commit InsightSoftwareConsortium/ITK@99f04d7 "ENH: Add static member function `BSplineKernelFunction::FastEvaluate(u)`" - ITK pull request InsightSoftwareConsortium/ITK#2731 commit InsightSoftwareConsortium/ITK@760ae12 "ENH: Add static `FastEvaluate(u)` to `BSplineDerivativeKernelFunction`"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added static member function
FastEvaluate(u)toBSplineDerivativeKernelFunction, just like the one added toBSplineKernelFunction.Used the
FastEvaluate(u)member functions of bothBSplineKernelFunctionandBSplineDerivativeKernelFunctioninside the implementation ofMattesMutualInformationImageToImageMetricandMattesMutualInformationImageToImageMetricv4.Follow-up to pull request #2716 "PERF:
BSplineKernelFunction::FastEvaluate(u): a faster way to evaluate BSplineKernelFunction"